phantom/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-01-26 03:03:22 -03:00
Code Issues Projects Releases Packages Wiki Activity Actions

test: avoid generating non-loopback traffic from p2p_dns_seeds.py

Browse source 
`p2p_dns_seeds.py` would try to connect to the DNS server configured on
the machine and resolve `dummySeed.invalid`.

To block that configure an unavailable proxy which will be used also to
connect to the name server. The test needs 2 successful connections to
other peers (two Python `P2PInterface`s) and they work in spite of the
unavailable proxy because they are on `127.0.0.1` (`NET_UNROUTABLE`) and
the proxy is not used for that.
This commit is contained in:
Vasil Dimov 2024-11-26 15:14:41 +01:00
parent 1b3abe86f9
commit 3eb4ad7740
No known key found for this signature in database
GPG key ID: 54DF06F64B55CBBF
1 changed files with 9 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
test/functional/p2p_dns_seeds.py
View file

@ -10,11 +10,16 @@ from test_framework.p2p import P2PInterface
from test_framework.test_framework import BitcoinTestFramework from test_framework.test_framework import BitcoinTestFramework
# Easily unreachable address. Attempts to connect to it will stay within the machine.
# Used to avoid non-loopback traffic or DNS queries.
DUMMY_PROXY_ARG = '-proxy=127.0.0.1:1'
class P2PDNSSeeds(BitcoinTestFramework): class P2PDNSSeeds(BitcoinTestFramework):
def set_test_params(self): def set_test_params(self):
self.setup_clean_chain = True self.setup_clean_chain = True
self.num_nodes = 1 self.num_nodes = 1
self.extra_args = [["-dnsseed=1"]] self.extra_args = [["-dnsseed=1", DUMMY_PROXY_ARG]]
def run_test(self): def run_test(self):
self.init_arg_tests() self.init_arg_tests()
@ -29,11 +34,11 @@ class P2PDNSSeeds(BitcoinTestFramework):
self.log.info("Check that setting -connect disables -dnsseed by default") self.log.info("Check that setting -connect disables -dnsseed by default")
self.nodes[0].stop_node() self.nodes[0].stop_node()
with self.nodes[0].assert_debug_log(expected_msgs=["DNS seeding disabled"]): with self.nodes[0].assert_debug_log(expected_msgs=["DNS seeding disabled"]):
self.start_node(0, [f"-connect={fakeaddr}"]) self.start_node(0, extra_args=[f"-connect={fakeaddr}", DUMMY_PROXY_ARG])
self.log.info("Check that running -connect and -dnsseed means DNS logic runs.") self.log.info("Check that running -connect and -dnsseed means DNS logic runs.")
with self.nodes[0].assert_debug_log(expected_msgs=["Loading addresses from DNS seed"], timeout=12): with self.nodes[0].assert_debug_log(expected_msgs=["Loading addresses from DNS seed"], timeout=12):
self.restart_node(0, [f"-connect={fakeaddr}", "-dnsseed=1"]) self.restart_node(0, extra_args=[f"-connect={fakeaddr}", "-dnsseed=1", DUMMY_PROXY_ARG])
self.log.info("Check that running -forcednsseed and -dnsseed=0 throws an error.") self.log.info("Check that running -forcednsseed and -dnsseed=0 throws an error.")
self.nodes[0].stop_node() self.nodes[0].stop_node()
@ -88,7 +93,7 @@ class P2PDNSSeeds(BitcoinTestFramework):
with self.nodes[0].assert_debug_log(expected_msgs=["Loading addresses from DNS seed"], timeout=12): with self.nodes[0].assert_debug_log(expected_msgs=["Loading addresses from DNS seed"], timeout=12):
# -dnsseed defaults to 1 in bitcoind, but 0 in the test framework, # -dnsseed defaults to 1 in bitcoind, but 0 in the test framework,
# so pass it explicitly here # so pass it explicitly here
self.restart_node(0, ["-forcednsseed", "-dnsseed=1"]) self.restart_node(0, ["-forcednsseed", "-dnsseed=1", DUMMY_PROXY_ARG])
# Restore default for subsequent tests # Restore default for subsequent tests
self.restart_node(0) self.restart_node(0)