phantom/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-04-29 23:09:44 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

test: fix accurate multisig sigop count (BIP16), add unit test

Browse source
This commit is contained in:
Sebastian Falbesoner 2024-03-10 20:18:19 +01:00
parent 4cc99df44a
commit 3e9c736a26
1 changed files with 16 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
test/functional/test_framework/script.py
View file

@ -483,7 +483,7 @@ class CScript(bytes):
i = 0 i = 0
while i < len(self): while i < len(self):
sop_idx = i sop_idx = i
opcode = self[i] opcode = CScriptOp(self[i])
i += 1 i += 1
if opcode > OP_PUSHDATA4: if opcode > OP_PUSHDATA4:
@ -590,7 +590,7 @@ class CScript(bytes):
n += 1 n += 1
elif opcode in (OP_CHECKMULTISIG, OP_CHECKMULTISIGVERIFY): elif opcode in (OP_CHECKMULTISIG, OP_CHECKMULTISIGVERIFY):
if fAccurate and (OP_1 <= lastOpcode <= OP_16): if fAccurate and (OP_1 <= lastOpcode <= OP_16):
n += opcode.decode_op_n() n += lastOpcode.decode_op_n()
else: else:
n += 20 n += 20
lastOpcode = opcode lastOpcode = opcode
@ -782,6 +782,20 @@ class TestFrameworkScript(unittest.TestCase):
for value in values: for value in values:
self.assertEqual(CScriptNum.decode(CScriptNum.encode(CScriptNum(value))), value) self.assertEqual(CScriptNum.decode(CScriptNum.encode(CScriptNum(value))), value)
def test_legacy_sigopcount(self):
# test repeated single sig ops
for n_ops in range(1, 100, 10):
for singlesig_op in (OP_CHECKSIG, OP_CHECKSIGVERIFY):
singlesigs_script = CScript([singlesig_op]*n_ops)
self.assertEqual(singlesigs_script.GetSigOpCount(fAccurate=False), n_ops)
self.assertEqual(singlesigs_script.GetSigOpCount(fAccurate=True), n_ops)
# test multisig op (including accurate counting, i.e. BIP16)
for n in range(1, 16+1):
for multisig_op in (OP_CHECKMULTISIG, OP_CHECKMULTISIGVERIFY):
multisig_script = CScript([CScriptOp.encode_op_n(n), multisig_op])
self.assertEqual(multisig_script.GetSigOpCount(fAccurate=False), 20)
self.assertEqual(multisig_script.GetSigOpCount(fAccurate=True), n)
def BIP341_sha_prevouts(txTo): def BIP341_sha_prevouts(txTo):
return sha256(b"".join(i.prevout.serialize() for i in txTo.vin)) return sha256(b"".join(i.prevout.serialize() for i in txTo.vin))