From 9ecff997e164e70c5958116b20ed441404ccd6f3 Mon Sep 17 00:00:00 2001 From: Andrew Chow Date: Thu, 6 Jul 2023 11:01:44 -0400 Subject: [PATCH 1/2] rpc: Drop migratewallet experimental warning --- src/wallet/rpc/wallet.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/src/wallet/rpc/wallet.cpp b/src/wallet/rpc/wallet.cpp index fb4b642bbab..a40fd7d3112 100644 --- a/src/wallet/rpc/wallet.cpp +++ b/src/wallet/rpc/wallet.cpp @@ -739,7 +739,6 @@ RPCHelpMan simulaterawtransaction() static RPCHelpMan migratewallet() { return RPCHelpMan{"migratewallet", - "EXPERIMENTAL warning: This call may not work as expected and may be changed in future releases\n" "\nMigrate the wallet to a descriptor wallet.\n" "A new wallet backup will need to be made.\n" "\nThe migration process will create a backup of the wallet before migrating. This backup\n" From f1684bb88a878eb3f54e945db39ea69b14256eef Mon Sep 17 00:00:00 2001 From: Andrew Chow Date: Thu, 19 Oct 2023 09:43:00 -0400 Subject: [PATCH 2/2] rpc: mention that migratewallet can take a while --- src/wallet/rpc/wallet.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/wallet/rpc/wallet.cpp b/src/wallet/rpc/wallet.cpp index a40fd7d3112..dd75afcc7ad 100644 --- a/src/wallet/rpc/wallet.cpp +++ b/src/wallet/rpc/wallet.cpp @@ -744,7 +744,8 @@ static RPCHelpMan migratewallet() "\nThe migration process will create a backup of the wallet before migrating. This backup\n" "file will be named -.legacy.bak and can be found in the directory\n" "for this wallet. In the event of an incorrect migration, the backup can be restored using restorewallet." - "\nEncrypted wallets must have the passphrase provided as an argument to this call.", + "\nEncrypted wallets must have the passphrase provided as an argument to this call.\n" + "\nThis RPC may take a long time to complete. Increasing the RPC client timeout is recommended.", { {"wallet_name", RPCArg::Type::STR, RPCArg::DefaultHint{"the wallet name from the RPC endpoint"}, "The name of the wallet to migrate. If provided both here and in the RPC endpoint, the two must be identical."}, {"passphrase", RPCArg::Type::STR, RPCArg::Optional::OMITTED, "The wallet passphrase"},