phantom/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-04-29 14:59:39 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Merge bitcoin/bitcoin#32282: torcontrol: Fix addrOnion outdated comment

Browse source 
bcaa23a2b7 torcontrol: Fix addrOnion outdate comment (Eval EXEC)

Pull request description:

  `m_randomize_credentials` is outdated name, remove it.
  Ref: https://github.com/bitcoin/bitcoin/pull/32176#discussion_r2044977356

ACKs for top commit:
  achow101:
    ACK bcaa23a2b7
  laanwj:
    ACK bcaa23a2b7
  w0xlt:
    ACK bcaa23a2b7
  jonatack:
    ACK bcaa23a2b7

Tree-SHA512: 38ba9b37e560598605077da7a84c455aa1a7e49365c417ceceff85a18de2af393b164cc8c93cdd6da9eac4d41f046f0ed12bc0f6833fe606c412ce7f1fce5189
This commit is contained in:
Ava Chow 2025-04-18 15:04:50 -07:00
commit 33d40a6ad4
No known key found for this signature in database
GPG key ID: 17565732E08E5E41
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/torcontrol.cpp
View file

@ -404,9 +404,9 @@ void TorController::get_socks_cb(TorControlConnection& _conn, const TorControlRe
Assume(resolved.IsValid()); Assume(resolved.IsValid());
LogDebug(BCLog::TOR, "Configuring onion proxy for %s\n", resolved.ToStringAddrPort()); LogDebug(BCLog::TOR, "Configuring onion proxy for %s\n", resolved.ToStringAddrPort());
// With m_randomize_credentials = true, generates unique SOCKS credentials per proxy connection (e.g., Tor). // Add Tor as proxy for .onion addresses.
// Prevents connection correlation and enhances privacy by forcing different Tor circuits. // Enable stream isolation to prevent connection correlation and enhance privacy, by forcing a different Tor circuit for every connection.
// Requires Tor's IsolateSOCKSAuth (default enabled) for effective isolation (see IsolateSOCKSAuth section in https://2019.www.torproject.org/docs/tor-manual.html.en). // For this to work, the IsolateSOCKSAuth flag must be enabled on SOCKSPort (which is the default, see the IsolateSOCKSAuth section of Tor's manual page).
Proxy addrOnion = Proxy(resolved, /*tor_stream_isolation=*/ true); Proxy addrOnion = Proxy(resolved, /*tor_stream_isolation=*/ true);
SetProxy(NET_ONION, addrOnion); SetProxy(NET_ONION, addrOnion);