diff --git a/ci/test/00_setup_env_native_fuzz_with_valgrind.sh b/ci/test/00_setup_env_native_fuzz_with_valgrind.sh index 2e500abf821..cc3a7c328eb 100755 --- a/ci/test/00_setup_env_native_fuzz_with_valgrind.sh +++ b/ci/test/00_setup_env_native_fuzz_with_valgrind.sh @@ -8,7 +8,7 @@ export LC_ALL=C.UTF-8 export CI_IMAGE_NAME_TAG="mirror.gcr.io/ubuntu:24.04" export CONTAINER_NAME=ci_native_fuzz_valgrind -export PACKAGES="clang-16 llvm-16 libclang-rt-16-dev libevent-dev libboost-dev libsqlite3-dev valgrind" +export PACKAGES="libevent-dev libboost-dev libsqlite3-dev valgrind" export NO_DEPENDS=1 export RUN_UNIT_TESTS=false export RUN_FUNCTIONAL_TESTS=false @@ -17,8 +17,4 @@ export FUZZ_TESTS_CONFIG="--valgrind" export GOAL="all" export BITCOIN_CONFIG="\ -DBUILD_FOR_FUZZING=ON \ - -DSANITIZERS=fuzzer \ - -DCMAKE_C_COMPILER=clang-16 \ - -DCMAKE_CXX_COMPILER=clang++-16 \ " -export LLVM_SYMBOLIZER_PATH="/usr/bin/llvm-symbolizer-16" diff --git a/ci/test/00_setup_env_native_valgrind.sh b/ci/test/00_setup_env_native_valgrind.sh index 22d9d812404..347a1135056 100755 --- a/ci/test/00_setup_env_native_valgrind.sh +++ b/ci/test/00_setup_env_native_valgrind.sh @@ -8,7 +8,7 @@ export LC_ALL=C.UTF-8 export CI_IMAGE_NAME_TAG="mirror.gcr.io/ubuntu:24.04" export CONTAINER_NAME=ci_native_valgrind -export PACKAGES="valgrind clang-16 llvm-16 libclang-rt-16-dev python3-zmq libevent-dev libboost-dev libdb5.3++-dev libzmq3-dev libsqlite3-dev" +export PACKAGES="valgrind python3-zmq libevent-dev libboost-dev libdb5.3++-dev libzmq3-dev libsqlite3-dev" export USE_VALGRIND=1 export NO_DEPENDS=1 export TEST_RUNNER_EXTRA="--exclude feature_init,rpc_bind,feature_bind_extra" # feature_init excluded for now, see https://github.com/bitcoin/bitcoin/issues/30011 ; bind tests excluded for now, see https://github.com/bitcoin/bitcoin/issues/17765#issuecomment-602068547 @@ -16,6 +16,4 @@ export GOAL="install" # TODO enable GUI export BITCOIN_CONFIG="\ -DWITH_ZMQ=ON -DWITH_BDB=ON -DWARN_INCOMPATIBLE_BDB=OFF -DBUILD_GUI=OFF \ - -DCMAKE_C_COMPILER=clang-16 \ - -DCMAKE_CXX_COMPILER=clang++-16 \ " diff --git a/contrib/valgrind.supp b/contrib/valgrind.supp index 9a9e640c615..a0a82d05010 100644 --- a/contrib/valgrind.supp +++ b/contrib/valgrind.supp @@ -12,9 +12,8 @@ # --error-limit=no build/bin/test_bitcoin # # Note that suppressions may depend on OS and/or library versions. -# Tested on: -# * aarch64 (Ubuntu Noble system libs, clang, without gui) -# * x86_64 (Ubuntu Noble system libs, clang, without gui) +# Tested on aarch64 and x86_64 with Ubuntu Noble system libs, using clang-16 +# and GCC, without gui. { Suppress libdb warning - https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=662917 Memcheck:Cond diff --git a/src/net_processing.cpp b/src/net_processing.cpp index a39c81d13a8..0b25396dd21 100644 --- a/src/net_processing.cpp +++ b/src/net_processing.cpp @@ -6,40 +6,55 @@ #include #include +#include #include #include #include +#include #include +#include #include +#include #include +#include +#include #include -#include +#include #include #include #include -#include #include #include +#include +#include +#include #include #include #include +#include +#include #include #include #include #include +#include #include +#include #include -#include #include #include +#include #include #include +#include