phantom/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-01-10 03:47:29 -03:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Merge bitcoin/bitcoin#24375: Do not use LocalTestingSetup in getarg_tests test file.

Browse source 
5d7f22595f Do not use `LocalTestingSetup` in getarg_tests test file. (Kiminuo)

Pull request description:

  Avoid using a test fixture in getarg_tests for better readability. Change was implemented by _kiminuo_ and posted https://github.com/bitcoin/bitcoin/pull/24306#issuecomment-1036643216

ACKs for top commit:
  kiminuo:
    ACK 5d7f22595f

Tree-SHA512: 0fd98622010e6923e91c66447a1d0861bf344a65d86a313dff7d428c089b1740a25f699327f6ed4c163255f270bcbd4f7be962bb551862214f9b9e395d40df04
This commit is contained in:
MarcoFalke 2022-03-02 12:09:18 +01:00
commit 08bcfa2767
No known key found for this signature in database
GPG key ID: CE2B75697E69A548
1 changed files with 167 additions and 165 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

332
src/test/getarg_tests.cpp
View file

@ -14,22 +14,13 @@
#include <boost/algorithm/string.hpp> #include <boost/algorithm/string.hpp>
#include <boost/test/unit_test.hpp> #include <boost/test/unit_test.hpp>
namespace getarg_tests{ BOOST_FIXTURE_TEST_SUITE(getarg_tests, BasicTestingSetup)
class LocalTestingSetup : BasicTestingSetup {
protected:
void SetupArgs(const std::vector<std::pair<std::string, unsigned int>>& args);
void ResetArgs(const std::string& strArg);
ArgsManager m_local_args;
};
}
BOOST_FIXTURE_TEST_SUITE(getarg_tests, LocalTestingSetup) void ResetArgs(ArgsManager& local_args, const std::string& strArg)
void LocalTestingSetup :: ResetArgs(const std::string& strArg)
{ {
std::vector<std::string> vecArg; std::vector<std::string> vecArg;
if (strArg.size()) if (strArg.size())
boost::split(vecArg, strArg, IsSpace, boost::token_compress_on); boost::split(vecArg, strArg, IsSpace, boost::token_compress_on);
// Insert dummy executable name: // Insert dummy executable name:
vecArg.insert(vecArg.begin(), "testbitcoin"); vecArg.insert(vecArg.begin(), "testbitcoin");
@ -40,264 +31,275 @@ void LocalTestingSetup :: ResetArgs(const std::string& strArg)
vecChar.push_back(s.c_str()); vecChar.push_back(s.c_str());
std::string error; std::string error;
BOOST_CHECK(m_local_args.ParseParameters(vecChar.size(), vecChar.data(), error)); BOOST_CHECK(local_args.ParseParameters(vecChar.size(), vecChar.data(), error));
} }
void LocalTestingSetup :: SetupArgs(const std::vector<std::pair<std::string, unsigned int>>& args) void SetupArgs(ArgsManager& local_args, const std::vector<std::pair<std::string, unsigned int>>& args)
{ {
m_local_args.ClearArgs();
for (const auto& arg : args) { for (const auto& arg : args) {
m_local_args.AddArg(arg.first, "", arg.second, OptionsCategory::OPTIONS); local_args.AddArg(arg.first, "", arg.second, OptionsCategory::OPTIONS);
} }
} }
BOOST_AUTO_TEST_CASE(boolarg) BOOST_AUTO_TEST_CASE(boolarg)
{ {
ArgsManager local_args;
const auto foo = std::make_pair("-foo", ArgsManager::ALLOW_ANY); const auto foo = std::make_pair("-foo", ArgsManager::ALLOW_ANY);
SetupArgs({foo}); SetupArgs(local_args, {foo});
ResetArgs("-foo"); ResetArgs(local_args, "-foo");
BOOST_CHECK(m_local_args.GetBoolArg("-foo", false)); BOOST_CHECK(local_args.GetBoolArg("-foo", false));
BOOST_CHECK(m_local_args.GetBoolArg("-foo", true)); BOOST_CHECK(local_args.GetBoolArg("-foo", true));
BOOST_CHECK(!m_local_args.GetBoolArg("-fo", false)); BOOST_CHECK(!local_args.GetBoolArg("-fo", false));
BOOST_CHECK(m_local_args.GetBoolArg("-fo", true)); BOOST_CHECK(local_args.GetBoolArg("-fo", true));
BOOST_CHECK(!m_local_args.GetBoolArg("-fooo", false)); BOOST_CHECK(!local_args.GetBoolArg("-fooo", false));
BOOST_CHECK(m_local_args.GetBoolArg("-fooo", true)); BOOST_CHECK(local_args.GetBoolArg("-fooo", true));
ResetArgs("-foo=0"); ResetArgs(local_args, "-foo=0");
BOOST_CHECK(!m_local_args.GetBoolArg("-foo", false)); BOOST_CHECK(!local_args.GetBoolArg("-foo", false));
BOOST_CHECK(!m_local_args.GetBoolArg("-foo", true)); BOOST_CHECK(!local_args.GetBoolArg("-foo", true));
ResetArgs("-foo=1"); ResetArgs(local_args, "-foo=1");
BOOST_CHECK(m_local_args.GetBoolArg("-foo", false)); BOOST_CHECK(local_args.GetBoolArg("-foo", false));
BOOST_CHECK(m_local_args.GetBoolArg("-foo", true)); BOOST_CHECK(local_args.GetBoolArg("-foo", true));
// New 0.6 feature: auto-map -nosomething to !-something: // New 0.6 feature: auto-map -nosomething to !-something:
ResetArgs("-nofoo"); ResetArgs(local_args, "-nofoo");
BOOST_CHECK(!m_local_args.GetBoolArg("-foo", false)); BOOST_CHECK(!local_args.GetBoolArg("-foo", false));
BOOST_CHECK(!m_local_args.GetBoolArg("-foo", true)); BOOST_CHECK(!local_args.GetBoolArg("-foo", true));
ResetArgs("-nofoo=1"); ResetArgs(local_args, "-nofoo=1");
BOOST_CHECK(!m_local_args.GetBoolArg("-foo", false)); BOOST_CHECK(!local_args.GetBoolArg("-foo", false));
BOOST_CHECK(!m_local_args.GetBoolArg("-foo", true)); BOOST_CHECK(!local_args.GetBoolArg("-foo", true));
ResetArgs("-foo -nofoo"); // -nofoo should win ResetArgs(local_args, "-foo -nofoo"); // -nofoo should win
BOOST_CHECK(!m_local_args.GetBoolArg("-foo", false)); BOOST_CHECK(!local_args.GetBoolArg("-foo", false));
BOOST_CHECK(!m_local_args.GetBoolArg("-foo", true)); BOOST_CHECK(!local_args.GetBoolArg("-foo", true));
ResetArgs("-foo=1 -nofoo=1"); // -nofoo should win ResetArgs(local_args, "-foo=1 -nofoo=1"); // -nofoo should win
BOOST_CHECK(!m_local_args.GetBoolArg("-foo", false)); BOOST_CHECK(!local_args.GetBoolArg("-foo", false));
BOOST_CHECK(!m_local_args.GetBoolArg("-foo", true)); BOOST_CHECK(!local_args.GetBoolArg("-foo", true));
ResetArgs("-foo=0 -nofoo=0"); // -nofoo=0 should win ResetArgs(local_args, "-foo=0 -nofoo=0"); // -nofoo=0 should win
BOOST_CHECK(m_local_args.GetBoolArg("-foo", false)); BOOST_CHECK(local_args.GetBoolArg("-foo", false));
BOOST_CHECK(m_local_args.GetBoolArg("-foo", true)); BOOST_CHECK(local_args.GetBoolArg("-foo", true));
// New 0.6 feature: treat -- same as -: // New 0.6 feature: treat -- same as -:
ResetArgs("--foo=1"); ResetArgs(local_args, "--foo=1");
BOOST_CHECK(m_local_args.GetBoolArg("-foo", false)); BOOST_CHECK(local_args.GetBoolArg("-foo", false));
BOOST_CHECK(m_local_args.GetBoolArg("-foo", true)); BOOST_CHECK(local_args.GetBoolArg("-foo", true));
ResetArgs("--nofoo=1");
BOOST_CHECK(!m_local_args.GetBoolArg("-foo", false));
BOOST_CHECK(!m_local_args.GetBoolArg("-foo", true));
ResetArgs(local_args, "--nofoo=1");
BOOST_CHECK(!local_args.GetBoolArg("-foo", false));
BOOST_CHECK(!local_args.GetBoolArg("-foo", true));
} }
BOOST_AUTO_TEST_CASE(stringarg) BOOST_AUTO_TEST_CASE(stringarg)
{ {
ArgsManager local_args;
const auto foo = std::make_pair("-foo", ArgsManager::ALLOW_ANY); const auto foo = std::make_pair("-foo", ArgsManager::ALLOW_ANY);
const auto bar = std::make_pair("-bar", ArgsManager::ALLOW_ANY); const auto bar = std::make_pair("-bar", ArgsManager::ALLOW_ANY);
SetupArgs({foo, bar}); SetupArgs(local_args, {foo, bar});
ResetArgs(""); ResetArgs(local_args, "");
BOOST_CHECK_EQUAL(m_local_args.GetArg("-foo", ""), ""); BOOST_CHECK_EQUAL(local_args.GetArg("-foo", ""), "");
BOOST_CHECK_EQUAL(m_local_args.GetArg("-foo", "eleven"), "eleven"); BOOST_CHECK_EQUAL(local_args.GetArg("-foo", "eleven"), "eleven");
ResetArgs("-foo -bar"); ResetArgs(local_args, "-foo -bar");
BOOST_CHECK_EQUAL(m_local_args.GetArg("-foo", ""), ""); BOOST_CHECK_EQUAL(local_args.GetArg("-foo", ""), "");
BOOST_CHECK_EQUAL(m_local_args.GetArg("-foo", "eleven"), ""); BOOST_CHECK_EQUAL(local_args.GetArg("-foo", "eleven"), "");
ResetArgs("-foo="); ResetArgs(local_args, "-foo=");
BOOST_CHECK_EQUAL(m_local_args.GetArg("-foo", ""), ""); BOOST_CHECK_EQUAL(local_args.GetArg("-foo", ""), "");
BOOST_CHECK_EQUAL(m_local_args.GetArg("-foo", "eleven"), ""); BOOST_CHECK_EQUAL(local_args.GetArg("-foo", "eleven"), "");
ResetArgs("-foo=11"); ResetArgs(local_args, "-foo=11");
BOOST_CHECK_EQUAL(m_local_args.GetArg("-foo", ""), "11"); BOOST_CHECK_EQUAL(local_args.GetArg("-foo", ""), "11");
BOOST_CHECK_EQUAL(m_local_args.GetArg("-foo", "eleven"), "11"); BOOST_CHECK_EQUAL(local_args.GetArg("-foo", "eleven"), "11");
ResetArgs("-foo=eleven");
BOOST_CHECK_EQUAL(m_local_args.GetArg("-foo", ""), "eleven");
BOOST_CHECK_EQUAL(m_local_args.GetArg("-foo", "eleven"), "eleven");
ResetArgs(local_args, "-foo=eleven");
BOOST_CHECK_EQUAL(local_args.GetArg("-foo", ""), "eleven");
BOOST_CHECK_EQUAL(local_args.GetArg("-foo", "eleven"), "eleven");
} }
BOOST_AUTO_TEST_CASE(intarg) BOOST_AUTO_TEST_CASE(intarg)
{ {
ArgsManager local_args;
const auto foo = std::make_pair("-foo", ArgsManager::ALLOW_ANY); const auto foo = std::make_pair("-foo", ArgsManager::ALLOW_ANY);
const auto bar = std::make_pair("-bar", ArgsManager::ALLOW_ANY); const auto bar = std::make_pair("-bar", ArgsManager::ALLOW_ANY);
SetupArgs({foo, bar}); SetupArgs(local_args, {foo, bar});
ResetArgs(""); ResetArgs(local_args, "");
BOOST_CHECK_EQUAL(m_local_args.GetIntArg("-foo", 11), 11); BOOST_CHECK_EQUAL(local_args.GetIntArg("-foo", 11), 11);
BOOST_CHECK_EQUAL(m_local_args.GetIntArg("-foo", 0), 0); BOOST_CHECK_EQUAL(local_args.GetIntArg("-foo", 0), 0);
ResetArgs("-foo -bar"); ResetArgs(local_args, "-foo -bar");
BOOST_CHECK_EQUAL(m_local_args.GetIntArg("-foo", 11), 0); BOOST_CHECK_EQUAL(local_args.GetIntArg("-foo", 11), 0);
BOOST_CHECK_EQUAL(m_local_args.GetIntArg("-bar", 11), 0); BOOST_CHECK_EQUAL(local_args.GetIntArg("-bar", 11), 0);
// Check under-/overflow behavior. // Check under-/overflow behavior.
ResetArgs("-foo=-9223372036854775809 -bar=9223372036854775808"); ResetArgs(local_args, "-foo=-9223372036854775809 -bar=9223372036854775808");
BOOST_CHECK_EQUAL(m_local_args.GetIntArg("-foo", 0), std::numeric_limits<int64_t>::min()); BOOST_CHECK_EQUAL(local_args.GetIntArg("-foo", 0), std::numeric_limits<int64_t>::min());
BOOST_CHECK_EQUAL(m_local_args.GetIntArg("-bar", 0), std::numeric_limits<int64_t>::max()); BOOST_CHECK_EQUAL(local_args.GetIntArg("-bar", 0), std::numeric_limits<int64_t>::max());
ResetArgs("-foo=11 -bar=12"); ResetArgs(local_args, "-foo=11 -bar=12");
BOOST_CHECK_EQUAL(m_local_args.GetIntArg("-foo", 0), 11); BOOST_CHECK_EQUAL(local_args.GetIntArg("-foo", 0), 11);
BOOST_CHECK_EQUAL(m_local_args.GetIntArg("-bar", 11), 12); BOOST_CHECK_EQUAL(local_args.GetIntArg("-bar", 11), 12);
ResetArgs("-foo=NaN -bar=NotANumber"); ResetArgs(local_args, "-foo=NaN -bar=NotANumber");
BOOST_CHECK_EQUAL(m_local_args.GetIntArg("-foo", 1), 0); BOOST_CHECK_EQUAL(local_args.GetIntArg("-foo", 1), 0);
BOOST_CHECK_EQUAL(m_local_args.GetIntArg("-bar", 11), 0); BOOST_CHECK_EQUAL(local_args.GetIntArg("-bar", 11), 0);
} }
BOOST_AUTO_TEST_CASE(patharg) BOOST_AUTO_TEST_CASE(patharg)
{ {
ArgsManager local_args;
const auto dir = std::make_pair("-dir", ArgsManager::ALLOW_ANY); const auto dir = std::make_pair("-dir", ArgsManager::ALLOW_ANY);
SetupArgs({dir}); SetupArgs(local_args, {dir});
ResetArgs(""); ResetArgs(local_args, "");
BOOST_CHECK_EQUAL(m_local_args.GetPathArg("-dir"), fs::path{}); BOOST_CHECK_EQUAL(local_args.GetPathArg("-dir"), fs::path{});
const fs::path root_path{"/"}; const fs::path root_path{"/"};
ResetArgs("-dir=/"); ResetArgs(local_args, "-dir=/");
BOOST_CHECK_EQUAL(m_local_args.GetPathArg("-dir"), root_path); BOOST_CHECK_EQUAL(local_args.GetPathArg("-dir"), root_path);
ResetArgs("-dir=/."); ResetArgs(local_args, "-dir=/.");
BOOST_CHECK_EQUAL(m_local_args.GetPathArg("-dir"), root_path); BOOST_CHECK_EQUAL(local_args.GetPathArg("-dir"), root_path);
ResetArgs("-dir=/./"); ResetArgs(local_args, "-dir=/./");
BOOST_CHECK_EQUAL(m_local_args.GetPathArg("-dir"), root_path); BOOST_CHECK_EQUAL(local_args.GetPathArg("-dir"), root_path);
ResetArgs("-dir=/.//"); ResetArgs(local_args, "-dir=/.//");
BOOST_CHECK_EQUAL(m_local_args.GetPathArg("-dir"), root_path); BOOST_CHECK_EQUAL(local_args.GetPathArg("-dir"), root_path);
#ifdef WIN32 #ifdef WIN32
const fs::path win_root_path{"C:\\"}; const fs::path win_root_path{"C:\\"};
ResetArgs("-dir=C:\\"); ResetArgs(local_args, "-dir=C:\\");
BOOST_CHECK_EQUAL(m_local_args.GetPathArg("-dir"), win_root_path); BOOST_CHECK_EQUAL(local_args.GetPathArg("-dir"), win_root_path);
ResetArgs("-dir=C:/"); ResetArgs(local_args, "-dir=C:/");
BOOST_CHECK_EQUAL(m_local_args.GetPathArg("-dir"), win_root_path); BOOST_CHECK_EQUAL(local_args.GetPathArg("-dir"), win_root_path);
ResetArgs("-dir=C:\\\\"); ResetArgs(local_args, "-dir=C:\\\\");
BOOST_CHECK_EQUAL(m_local_args.GetPathArg("-dir"), win_root_path); BOOST_CHECK_EQUAL(local_args.GetPathArg("-dir"), win_root_path);
ResetArgs("-dir=C:\\."); ResetArgs(local_args, "-dir=C:\\.");
BOOST_CHECK_EQUAL(m_local_args.GetPathArg("-dir"), win_root_path); BOOST_CHECK_EQUAL(local_args.GetPathArg("-dir"), win_root_path);
ResetArgs("-dir=C:\\.\\"); ResetArgs(local_args, "-dir=C:\\.\\");
BOOST_CHECK_EQUAL(m_local_args.GetPathArg("-dir"), win_root_path); BOOST_CHECK_EQUAL(local_args.GetPathArg("-dir"), win_root_path);
ResetArgs("-dir=C:\\.\\\\"); ResetArgs(local_args, "-dir=C:\\.\\\\");
BOOST_CHECK_EQUAL(m_local_args.GetPathArg("-dir"), win_root_path); BOOST_CHECK_EQUAL(local_args.GetPathArg("-dir"), win_root_path);
#endif #endif
const fs::path absolute_path{"/home/user/.bitcoin"}; const fs::path absolute_path{"/home/user/.bitcoin"};
ResetArgs("-dir=/home/user/.bitcoin"); ResetArgs(local_args, "-dir=/home/user/.bitcoin");
BOOST_CHECK_EQUAL(m_local_args.GetPathArg("-dir"), absolute_path); BOOST_CHECK_EQUAL(local_args.GetPathArg("-dir"), absolute_path);
ResetArgs("-dir=/root/../home/user/.bitcoin"); ResetArgs(local_args, "-dir=/root/../home/user/.bitcoin");
BOOST_CHECK_EQUAL(m_local_args.GetPathArg("-dir"), absolute_path); BOOST_CHECK_EQUAL(local_args.GetPathArg("-dir"), absolute_path);
ResetArgs("-dir=/home/./user/.bitcoin"); ResetArgs(local_args, "-dir=/home/./user/.bitcoin");
BOOST_CHECK_EQUAL(m_local_args.GetPathArg("-dir"), absolute_path); BOOST_CHECK_EQUAL(local_args.GetPathArg("-dir"), absolute_path);
ResetArgs("-dir=/home/user/.bitcoin/"); ResetArgs(local_args, "-dir=/home/user/.bitcoin/");
BOOST_CHECK_EQUAL(m_local_args.GetPathArg("-dir"), absolute_path); BOOST_CHECK_EQUAL(local_args.GetPathArg("-dir"), absolute_path);
ResetArgs("-dir=/home/user/.bitcoin//"); ResetArgs(local_args, "-dir=/home/user/.bitcoin//");
BOOST_CHECK_EQUAL(m_local_args.GetPathArg("-dir"), absolute_path); BOOST_CHECK_EQUAL(local_args.GetPathArg("-dir"), absolute_path);
ResetArgs("-dir=/home/user/.bitcoin/."); ResetArgs(local_args, "-dir=/home/user/.bitcoin/.");
BOOST_CHECK_EQUAL(m_local_args.GetPathArg("-dir"), absolute_path); BOOST_CHECK_EQUAL(local_args.GetPathArg("-dir"), absolute_path);
ResetArgs("-dir=/home/user/.bitcoin/./"); ResetArgs(local_args, "-dir=/home/user/.bitcoin/./");
BOOST_CHECK_EQUAL(m_local_args.GetPathArg("-dir"), absolute_path); BOOST_CHECK_EQUAL(local_args.GetPathArg("-dir"), absolute_path);
ResetArgs("-dir=/home/user/.bitcoin/.//"); ResetArgs(local_args, "-dir=/home/user/.bitcoin/.//");
BOOST_CHECK_EQUAL(m_local_args.GetPathArg("-dir"), absolute_path); BOOST_CHECK_EQUAL(local_args.GetPathArg("-dir"), absolute_path);
const fs::path relative_path{"user/.bitcoin"}; const fs::path relative_path{"user/.bitcoin"};
ResetArgs("-dir=user/.bitcoin"); ResetArgs(local_args, "-dir=user/.bitcoin");
BOOST_CHECK_EQUAL(m_local_args.GetPathArg("-dir"), relative_path); BOOST_CHECK_EQUAL(local_args.GetPathArg("-dir"), relative_path);
ResetArgs("-dir=somewhere/../user/.bitcoin"); ResetArgs(local_args, "-dir=somewhere/../user/.bitcoin");
BOOST_CHECK_EQUAL(m_local_args.GetPathArg("-dir"), relative_path); BOOST_CHECK_EQUAL(local_args.GetPathArg("-dir"), relative_path);
ResetArgs("-dir=user/./.bitcoin"); ResetArgs(local_args, "-dir=user/./.bitcoin");
BOOST_CHECK_EQUAL(m_local_args.GetPathArg("-dir"), relative_path); BOOST_CHECK_EQUAL(local_args.GetPathArg("-dir"), relative_path);
ResetArgs("-dir=user/.bitcoin/"); ResetArgs(local_args, "-dir=user/.bitcoin/");
BOOST_CHECK_EQUAL(m_local_args.GetPathArg("-dir"), relative_path); BOOST_CHECK_EQUAL(local_args.GetPathArg("-dir"), relative_path);
ResetArgs("-dir=user/.bitcoin//"); ResetArgs(local_args, "-dir=user/.bitcoin//");
BOOST_CHECK_EQUAL(m_local_args.GetPathArg("-dir"), relative_path); BOOST_CHECK_EQUAL(local_args.GetPathArg("-dir"), relative_path);
ResetArgs("-dir=user/.bitcoin/."); ResetArgs(local_args, "-dir=user/.bitcoin/.");
BOOST_CHECK_EQUAL(m_local_args.GetPathArg("-dir"), relative_path); BOOST_CHECK_EQUAL(local_args.GetPathArg("-dir"), relative_path);
ResetArgs("-dir=user/.bitcoin/./"); ResetArgs(local_args, "-dir=user/.bitcoin/./");
BOOST_CHECK_EQUAL(m_local_args.GetPathArg("-dir"), relative_path); BOOST_CHECK_EQUAL(local_args.GetPathArg("-dir"), relative_path);
ResetArgs("-dir=user/.bitcoin/.//"); ResetArgs(local_args, "-dir=user/.bitcoin/.//");
BOOST_CHECK_EQUAL(m_local_args.GetPathArg("-dir"), relative_path); BOOST_CHECK_EQUAL(local_args.GetPathArg("-dir"), relative_path);
} }
BOOST_AUTO_TEST_CASE(doubledash) BOOST_AUTO_TEST_CASE(doubledash)
{ {
ArgsManager local_args;
const auto foo = std::make_pair("-foo", ArgsManager::ALLOW_ANY); const auto foo = std::make_pair("-foo", ArgsManager::ALLOW_ANY);
const auto bar = std::make_pair("-bar", ArgsManager::ALLOW_ANY); const auto bar = std::make_pair("-bar", ArgsManager::ALLOW_ANY);
SetupArgs({foo, bar}); SetupArgs(local_args, {foo, bar});
ResetArgs("--foo"); ResetArgs(local_args, "--foo");
BOOST_CHECK_EQUAL(m_local_args.GetBoolArg("-foo", false), true); BOOST_CHECK_EQUAL(local_args.GetBoolArg("-foo", false), true);
ResetArgs("--foo=verbose --bar=1"); ResetArgs(local_args, "--foo=verbose --bar=1");
BOOST_CHECK_EQUAL(m_local_args.GetArg("-foo", ""), "verbose"); BOOST_CHECK_EQUAL(local_args.GetArg("-foo", ""), "verbose");
BOOST_CHECK_EQUAL(m_local_args.GetIntArg("-bar", 0), 1); BOOST_CHECK_EQUAL(local_args.GetIntArg("-bar", 0), 1);
} }
BOOST_AUTO_TEST_CASE(boolargno) BOOST_AUTO_TEST_CASE(boolargno)
{ {
ArgsManager local_args;
const auto foo = std::make_pair("-foo", ArgsManager::ALLOW_ANY); const auto foo = std::make_pair("-foo", ArgsManager::ALLOW_ANY);
const auto bar = std::make_pair("-bar", ArgsManager::ALLOW_ANY); const auto bar = std::make_pair("-bar", ArgsManager::ALLOW_ANY);
SetupArgs({foo, bar}); SetupArgs(local_args, {foo, bar});
ResetArgs("-nofoo"); ResetArgs(local_args, "-nofoo");
BOOST_CHECK(!m_local_args.GetBoolArg("-foo", true)); BOOST_CHECK(!local_args.GetBoolArg("-foo", true));
BOOST_CHECK(!m_local_args.GetBoolArg("-foo", false)); BOOST_CHECK(!local_args.GetBoolArg("-foo", false));
ResetArgs("-nofoo=1"); ResetArgs(local_args, "-nofoo=1");
BOOST_CHECK(!m_local_args.GetBoolArg("-foo", true)); BOOST_CHECK(!local_args.GetBoolArg("-foo", true));
BOOST_CHECK(!m_local_args.GetBoolArg("-foo", false)); BOOST_CHECK(!local_args.GetBoolArg("-foo", false));
ResetArgs("-nofoo=0"); ResetArgs(local_args, "-nofoo=0");
BOOST_CHECK(m_local_args.GetBoolArg("-foo", true)); BOOST_CHECK(local_args.GetBoolArg("-foo", true));
BOOST_CHECK(m_local_args.GetBoolArg("-foo", false)); BOOST_CHECK(local_args.GetBoolArg("-foo", false));
ResetArgs("-foo --nofoo"); // --nofoo should win ResetArgs(local_args, "-foo --nofoo"); // --nofoo should win
BOOST_CHECK(!m_local_args.GetBoolArg("-foo", true)); BOOST_CHECK(!local_args.GetBoolArg("-foo", true));
BOOST_CHECK(!m_local_args.GetBoolArg("-foo", false)); BOOST_CHECK(!local_args.GetBoolArg("-foo", false));
ResetArgs("-nofoo -foo"); // foo always wins: ResetArgs(local_args, "-nofoo -foo"); // foo always wins:
BOOST_CHECK(m_local_args.GetBoolArg("-foo", true)); BOOST_CHECK(local_args.GetBoolArg("-foo", true));
BOOST_CHECK(m_local_args.GetBoolArg("-foo", false)); BOOST_CHECK(local_args.GetBoolArg("-foo", false));
} }
BOOST_AUTO_TEST_CASE(logargs) BOOST_AUTO_TEST_CASE(logargs)
{ {
ArgsManager local_args;
const auto okaylog_bool = std::make_pair("-okaylog-bool", ArgsManager::ALLOW_ANY); const auto okaylog_bool = std::make_pair("-okaylog-bool", ArgsManager::ALLOW_ANY);
const auto okaylog_negbool = std::make_pair("-okaylog-negbool", ArgsManager::ALLOW_ANY); const auto okaylog_negbool = std::make_pair("-okaylog-negbool", ArgsManager::ALLOW_ANY);
const auto okaylog = std::make_pair("-okaylog", ArgsManager::ALLOW_ANY); const auto okaylog = std::make_pair("-okaylog", ArgsManager::ALLOW_ANY);
const auto dontlog = std::make_pair("-dontlog", ArgsManager::ALLOW_ANY | ArgsManager::SENSITIVE); const auto dontlog = std::make_pair("-dontlog", ArgsManager::ALLOW_ANY | ArgsManager::SENSITIVE);
SetupArgs({okaylog_bool, okaylog_negbool, okaylog, dontlog}); SetupArgs(local_args, {okaylog_bool, okaylog_negbool, okaylog, dontlog});
ResetArgs("-okaylog-bool -nookaylog-negbool -okaylog=public -dontlog=private"); ResetArgs(local_args, "-okaylog-bool -nookaylog-negbool -okaylog=public -dontlog=private");
// Everything logged to debug.log will also append to str // Everything logged to debug.log will also append to str
std::string str; std::string str;
@ -307,7 +309,7 @@ BOOST_AUTO_TEST_CASE(logargs)
}); });
// Log the arguments // Log the arguments
m_local_args.LogArgs(); local_args.LogArgs();
LogInstance().DeleteCallback(print_connection); LogInstance().DeleteCallback(print_connection);
// Check that what should appear does, and what shouldn't doesn't. // Check that what should appear does, and what shouldn't doesn't.