From 00e9b97f37e0bdf4c647236838c10b68b7ad5be3 Mon Sep 17 00:00:00 2001 From: TheCharlatan Date: Wed, 15 Mar 2023 11:18:06 +0100 Subject: [PATCH] refactor: Move fs.* to util/fs.* The fs.* files are already part of the libbitcoin_util library. With the introduction of the fs_helpers.* it makes sense to move fs.* into the util/ directory as well. --- src/Makefile.am | 6 +++--- src/addrdb.cpp | 2 +- src/addrdb.h | 2 +- src/banman.h | 2 +- src/bench/bench.cpp | 2 +- src/bench/bench.h | 2 +- src/bench/bench_bitcoin.cpp | 2 +- src/bitcoin-tx.cpp | 2 +- src/common/init.cpp | 4 ++-- src/dbwrapper.cpp | 2 +- src/dbwrapper.h | 2 +- src/flatfile.h | 2 +- src/i2p.cpp | 2 +- src/i2p.h | 2 +- src/init.cpp | 2 +- src/init/common.cpp | 2 +- src/interfaces/wallet.h | 2 +- src/ipc/interfaces.cpp | 2 +- src/ipc/process.cpp | 2 +- src/ipc/process.h | 2 +- src/kernel/mempool_persist.cpp | 2 +- src/kernel/mempool_persist.h | 2 +- src/logging.cpp | 2 +- src/logging.h | 2 +- src/net.cpp | 2 +- src/node/blockstorage.cpp | 2 +- src/node/blockstorage.h | 2 +- src/node/chainstate.cpp | 2 +- src/node/mempool_persist_args.cpp | 2 +- src/node/mempool_persist_args.h | 2 +- src/node/utxo_snapshot.cpp | 2 +- src/node/utxo_snapshot.h | 2 +- src/policy/fees.cpp | 2 +- src/policy/fees.h | 2 +- src/policy/fees_args.h | 2 +- src/qt/guiutil.cpp | 2 +- src/qt/guiutil.h | 2 +- src/qt/intro.cpp | 2 +- src/qt/psbtoperationsdialog.cpp | 2 +- src/qt/walletframe.cpp | 2 +- src/rpc/blockchain.cpp | 2 +- src/rpc/blockchain.h | 2 +- src/rpc/mempool.cpp | 2 +- src/rpc/request.cpp | 2 +- src/test/argsman_tests.cpp | 6 +++--- src/test/fs_tests.cpp | 2 +- src/test/fuzz/banman.cpp | 2 +- src/test/fuzz/fuzz.cpp | 2 +- src/test/fuzz/utxo_snapshot.cpp | 2 +- src/test/script_tests.cpp | 2 +- src/test/settings_tests.cpp | 2 +- src/test/streams_tests.cpp | 2 +- src/test/util/chainstate.h | 2 +- src/test/util/setup_common.h | 2 +- src/test/util_tests.cpp | 2 +- src/torcontrol.h | 2 +- src/txdb.h | 2 +- src/util/asmap.cpp | 2 +- src/util/asmap.h | 2 +- src/{ => util}/fs.cpp | 2 +- src/{ => util}/fs.h | 6 +++--- src/util/fs_helpers.cpp | 2 +- src/util/fs_helpers.h | 2 +- src/util/getuniquepath.cpp | 2 +- src/util/getuniquepath.h | 2 +- src/util/readwritefile.cpp | 2 +- src/util/readwritefile.h | 2 +- src/util/settings.cpp | 2 +- src/util/settings.h | 2 +- src/util/system.cpp | 2 +- src/util/system.h | 4 ++-- src/validation.cpp | 2 +- src/validation.h | 2 +- src/wallet/bdb.cpp | 2 +- src/wallet/bdb.h | 2 +- src/wallet/db.cpp | 2 +- src/wallet/db.h | 2 +- src/wallet/dump.cpp | 2 +- src/wallet/dump.h | 2 +- src/wallet/load.cpp | 2 +- src/wallet/rpc/backup.cpp | 2 +- src/wallet/salvage.cpp | 2 +- src/wallet/salvage.h | 2 +- src/wallet/test/db_tests.cpp | 2 +- src/wallet/test/init_test_fixture.cpp | 2 +- src/wallet/wallet.cpp | 2 +- src/wallet/wallet.h | 2 +- src/wallet/walletdb.cpp | 2 +- src/wallet/wallettool.cpp | 2 +- src/wallet/walletutil.h | 2 +- 90 files changed, 98 insertions(+), 98 deletions(-) rename src/{ => util}/fs.cpp (99%) rename src/{ => util}/fs.h (99%) diff --git a/src/Makefile.am b/src/Makefile.am index 9ce9a685018..444480f824a 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -154,7 +154,6 @@ BITCOIN_CORE_H = \ deploymentstatus.h \ external_signer.h \ flatfile.h \ - fs.h \ headerssync.h \ httprpc.h \ httpserver.h \ @@ -285,6 +284,7 @@ BITCOIN_CORE_H = \ util/exception.h \ util/fastrange.h \ util/fees.h \ + util/fs.h \ util/fs_helpers.h \ util/getuniquepath.h \ util/golombrice.h \ @@ -695,7 +695,6 @@ libbitcoin_util_a_SOURCES = \ support/lockedpool.cpp \ chainparamsbase.cpp \ clientversion.cpp \ - fs.cpp \ logging.cpp \ random.cpp \ randomenv.cpp \ @@ -708,6 +707,7 @@ libbitcoin_util_a_SOURCES = \ util/error.cpp \ util/exception.cpp \ util/fees.cpp \ + util/fs.cpp \ util/fs_helpers.cpp \ util/getuniquepath.cpp \ util/hasher.cpp \ @@ -910,7 +910,6 @@ libbitcoinkernel_la_SOURCES = \ deploymentinfo.cpp \ deploymentstatus.cpp \ flatfile.cpp \ - fs.cpp \ hash.cpp \ kernel/chain.cpp \ kernel/checks.cpp \ @@ -953,6 +952,7 @@ libbitcoinkernel_la_SOURCES = \ uint256.cpp \ util/check.cpp \ util/exception.cpp \ + util/fs.cpp \ util/fs_helpers.cpp \ util/getuniquepath.cpp \ util/hasher.cpp \ diff --git a/src/addrdb.cpp b/src/addrdb.cpp index 71da45ad3d8..8ecccd4d22e 100644 --- a/src/addrdb.cpp +++ b/src/addrdb.cpp @@ -9,7 +9,6 @@ #include #include #include -#include #include #include #include @@ -19,6 +18,7 @@ #include #include #include +#include #include #include #include diff --git a/src/addrdb.h b/src/addrdb.h index 627ef3ac3ce..08d86d0f01b 100644 --- a/src/addrdb.h +++ b/src/addrdb.h @@ -6,9 +6,9 @@ #ifndef BITCOIN_ADDRDB_H #define BITCOIN_ADDRDB_H -#include #include // For banmap_t #include +#include #include #include diff --git a/src/banman.h b/src/banman.h index 241f01dd2e3..5a5f5677b00 100644 --- a/src/banman.h +++ b/src/banman.h @@ -7,9 +7,9 @@ #include #include -#include #include // For banmap_t #include +#include #include #include diff --git a/src/bench/bench.cpp b/src/bench/bench.cpp index 4374a632508..84b66bc4b22 100644 --- a/src/bench/bench.cpp +++ b/src/bench/bench.cpp @@ -4,8 +4,8 @@ #include -#include #include +#include #include #include diff --git a/src/bench/bench.h b/src/bench/bench.h index 22c63a797b1..78196134e78 100644 --- a/src/bench/bench.h +++ b/src/bench/bench.h @@ -5,7 +5,7 @@ #ifndef BITCOIN_BENCH_BENCH_H #define BITCOIN_BENCH_BENCH_H -#include +#include #include #include diff --git a/src/bench/bench_bitcoin.cpp b/src/bench/bench_bitcoin.cpp index 06e32f684fd..7faaa1fb14e 100644 --- a/src/bench/bench_bitcoin.cpp +++ b/src/bench/bench_bitcoin.cpp @@ -6,7 +6,7 @@ #include #include -#include +#include #include #include diff --git a/src/bitcoin-tx.cpp b/src/bitcoin-tx.cpp index f36b6054bb0..a05443a2e5a 100644 --- a/src/bitcoin-tx.cpp +++ b/src/bitcoin-tx.cpp @@ -12,7 +12,6 @@ #include #include #include -#include #include #include #include @@ -21,6 +20,7 @@ #include