phantom/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-01-30 13:07:32 -03:00
Code Issues Projects Releases Packages Wiki Activity Actions 1
bitcoin/src/test/netbase_tests.cpp

592 lines
30 KiB
C++
Raw Normal View History

scripted-diff: Bump copyright headers -BEGIN VERIFY SCRIPT- ./contrib/devtools/copyright_header.py update ./ -END VERIFY SCRIPT-
2020-04-16 13:14:08 -04:00
// Copyright (c) 2012-2020 The Bitcoin Core developers
Remove references to X11 licence
2014-12-13 12:09:33 +08:00
// Distributed under the MIT software license, see the accompanying
Add licenses for tests and test data - Add license headers to source files (years based on commit dates) in `src/test` as well as `qa` - Add `README.md` to `src/test/data` specifying MIT license Fixes #3848
2014-03-18 10:11:00 +01:00
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
Make whitebind/whitelist permissions more flexible
2019-06-20 18:37:51 +09:00
#include <net_permissions.h>
test: add missing netaddress include headers
2021-03-06 20:14:08 +01:00
#include <netaddress.h>
scripted-diff: Sort test includes -BEGIN VERIFY SCRIPT- # Mark all lines with #includes sed -i --regexp-extended -e 's/(#include <.*>)/\1 /g' $(git grep -l '#include' ./src/bench/ ./src/test ./src/wallet/test/) # Sort all marked lines git diff -U0 | ./contrib/devtools/clang-format-diff.py -p1 -i -v -END VERIFY SCRIPT-
2020-04-16 13:11:54 -04:00
#include <netbase.h>
net: CAddress & CAddrMan: (un)serialize as ADDRv2 Change the serialization of `CAddrMan` to serialize its addresses in ADDRv2/BIP155 format by default. Introduce a new `CAddrMan` format version (3). Add support for ADDRv2 format in `CAddress` (un)serialization. Co-authored-by: Carl Dong <contact@carldong.me>
2020-05-19 17:39:05 +02:00
#include <protocol.h>
#include <serialize.h>
#include <streams.h>
scripted-diff: test: Move setup_common to test library -BEGIN VERIFY SCRIPT- # Move files for f in $(git ls-files src/test/lib/); do git mv $f src/test/util/; done git mv src/test/setup_common.cpp src/test/util/ git mv src/test/setup_common.h src/test/util/ # Replace Windows paths sed -i -e 's|\\setup_common|\\util\\setup_common|g' $(git grep -l '\\setup_common') sed -i -e 's|src\\test\\lib\\|src\\test\\util\\|g' build_msvc/test_bitcoin/test_bitcoin.vcxproj # Everything else sed -i -e 's|/setup_common|/util/setup_common|g' $(git grep -l 'setup_common') sed -i -e 's|test/lib/|test/util/|g' $(git grep -l 'test/lib/') # Fix include guard sed -i -e 's|BITCOIN_TEST_SETUP_COMMON_H|BITCOIN_TEST_UTIL_SETUP_COMMON_H|g' ./src/test/util/setup_common.h sed -i -e 's|BITCOIN_TEST_LIB_|BITCOIN_TEST_UTIL_|g' $(git grep -l 'BITCOIN_TEST_LIB_') -END VERIFY SCRIPT-
2019-11-05 15:18:59 -05:00
#include <test/util/setup_common.h>
scripted-diff: Move util files to separate directory. -BEGIN VERIFY SCRIPT- mkdir -p src/util git mv src/util.h src/util/system.h git mv src/util.cpp src/util/system.cpp git mv src/utilmemory.h src/util/memory.h git mv src/utilmoneystr.h src/util/moneystr.h git mv src/utilmoneystr.cpp src/util/moneystr.cpp git mv src/utilstrencodings.h src/util/strencodings.h git mv src/utilstrencodings.cpp src/util/strencodings.cpp git mv src/utiltime.h src/util/time.h git mv src/utiltime.cpp src/util/time.cpp sed -i 's/<util\.h>/<util\/system\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') sed -i 's/<utilmemory\.h>/<util\/memory\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') sed -i 's/<utilmoneystr\.h>/<util\/moneystr\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') sed -i 's/<utilstrencodings\.h>/<util\/strencodings\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') sed -i 's/<utiltime\.h>/<util\/time\.h>/g' $(git ls-files 'src/*.h' 'src/*.cpp') sed -i 's/BITCOIN_UTIL_H/BITCOIN_UTIL_SYSTEM_H/g' src/util/system.h sed -i 's/BITCOIN_UTILMEMORY_H/BITCOIN_UTIL_MEMORY_H/g' src/util/memory.h sed -i 's/BITCOIN_UTILMONEYSTR_H/BITCOIN_UTIL_MONEYSTR_H/g' src/util/moneystr.h sed -i 's/BITCOIN_UTILSTRENCODINGS_H/BITCOIN_UTIL_STRENCODINGS_H/g' src/util/strencodings.h sed -i 's/BITCOIN_UTILTIME_H/BITCOIN_UTIL_TIME_H/g' src/util/time.h sed -i 's/ util\.\(h\|cpp\)/ util\/system\.\1/g' src/Makefile.am sed -i 's/utilmemory\.\(h\|cpp\)/util\/memory\.\1/g' src/Makefile.am sed -i 's/utilmoneystr\.\(h\|cpp\)/util\/moneystr\.\1/g' src/Makefile.am sed -i 's/utilstrencodings\.\(h\|cpp\)/util\/strencodings\.\1/g' src/Makefile.am sed -i 's/utiltime\.\(h\|cpp\)/util\/time\.\1/g' src/Makefile.am sed -i 's/-> util ->/-> util\/system ->/' test/lint/lint-circular-dependencies.sh sed -i 's/src\/util\.cpp/src\/util\/system\.cpp/g' test/lint/lint-format-strings.py test/lint/lint-locale-dependence.sh sed -i 's/src\/utilmoneystr\.cpp/src\/util\/moneystr\.cpp/g' test/lint/lint-locale-dependence.sh sed -i 's/src\/utilstrencodings\.\(h\|cpp\)/src\/util\/strencodings\.\1/g' test/lint/lint-locale-dependence.sh sed -i 's/src\\utilstrencodings\.cpp/src\\util\\strencodings\.cpp/' build_msvc/libbitcoinconsensus/libbitcoinconsensus.vcxproj -END VERIFY SCRIPT-
2018-10-22 15:51:11 -07:00
#include <util/strencodings.h>
refactor: Error message bilingual_str consistency - Move the decision whether to translate an error message to where it is defined. This simplifies call sites: no more `InitError(Untranslated(...))`. - Make all functions in `util/error.h` consistently return a `bilingual_str`. We've decided to use this as error message type so let's roll with it. This has no functional changes: no messages are changed, no new translation messages are defined.
2020-06-05 14:26:16 +02:00
#include <util/translation.h>
net: CAddress & CAddrMan: (un)serialize as ADDRv2 Change the serialization of `CAddrMan` to serialize its addresses in ADDRv2/BIP155 format by default. Introduce a new `CAddrMan` format version (3). Add support for ADDRv2 format in `CAddress` (un)serialization. Co-authored-by: Carl Dong <contact@carldong.me>
2020-05-19 17:39:05 +02:00
#include <version.h>
Add netbase tests
2012-06-08 18:42:05 +02:00
#include <string>
Cleanup code using forward declarations. Use misc methods of avoiding unnecesary header includes. Replace int typedefs with int##_t from stdint.h. Replace PRI64[xdu] with PRI[xdu]64 from inttypes.h. Normalize QT_VERSION ifs where possible. Resolve some indirect dependencies as direct ones. Remove extern declarations from .cpp files.
2013-04-13 00:13:08 -05:00
#include <boost/test/unit_test.hpp>
Add netbase tests
2012-06-08 18:42:05 +02:00
test: fix creation of std::string objects with \0s A string literal `"abc"` contains a terminating `\0`, so that is 4 bytes. There is no need to write `"abc\0"` unless two terminating `\0`s are necessary. `std::string` objects do not internally contain a terminating `\0`, so `std::string("abc")` creates a string with size 3 and is the same as `std::string("abc", 3)`. In `"\01"` the `01` part is interpreted as one number (1) and that is the same as `"\1"` which is a string like `{1, 0}` whereas `"\0z"` is a string like `{0, 'z', 0}`. To create a string like `{0, '1', 0}` one must use `"\0" "1"`. Adjust the tests accordingly.
2020-09-23 08:40:38 +02:00
using namespace std::literals;
tests: add a BasicTestingSetup and apply to all tests Make sure that chainparams and logging is properly initialized. Doing this for every test may be overkill, but this initialization is so simple that that does not matter. This should fix the travis issues.
2015-03-12 09:34:42 +01:00
BOOST_FIXTURE_TEST_SUITE(netbase_tests, BasicTestingSetup)
Add netbase tests
2012-06-08 18:42:05 +02:00
tests: Avoid using C-style NUL-terminated strings as arguments
2019-12-29 20:23:48 +00:00
static CNetAddr ResolveIP(const std::string& ip)
net: Split resolving out of CNetAddr
2016-05-31 13:05:52 -04:00
{
CNetAddr addr;
LookupHost(ip, addr, false);
return addr;
}
tests: Avoid using C-style NUL-terminated strings as arguments
2019-12-29 20:23:48 +00:00
static CSubNet ResolveSubNet(const std::string& subnet)
net: Split resolving out of CSubNet
2016-05-31 15:50:24 -04:00
{
CSubNet ret;
LookupSubNet(subnet, ret);
return ret;
}
tests: Avoid using C-style NUL-terminated strings as arguments
2019-12-29 20:23:48 +00:00
static CNetAddr CreateInternal(const std::string& host)
net: add an internal subnet for representing unresolved hostnames We currently do two resolves for dns seeds: one for the results, and one to serve in addrman as the source for those addresses. There's no requirement that the source hostname resolves to the stored identifier, only that the mapping is unique. So rather than incurring the second lookup, combine a private subnet with a hash of the hostname. The resulting v6 ip is guaranteed not to be publicy routable, and has only a negligible chance of colliding with a user's internal network (which would be of no consequence anyway).
2017-05-23 20:04:38 -04:00
{
CNetAddr addr;
addr.SetInternal(host);
return addr;
}
Add netbase tests
2012-06-08 18:42:05 +02:00
BOOST_AUTO_TEST_CASE(netbase_networks)
{
net: Split resolving out of CNetAddr
2016-05-31 13:05:52 -04:00
BOOST_CHECK(ResolveIP("127.0.0.1").GetNetwork() == NET_UNROUTABLE);
BOOST_CHECK(ResolveIP("::1").GetNetwork() == NET_UNROUTABLE);
BOOST_CHECK(ResolveIP("8.8.8.8").GetNetwork() == NET_IPV4);
BOOST_CHECK(ResolveIP("2001::8888").GetNetwork() == NET_IPV6);
scripted-diff: Replace NET_TOR with NET_ONION -BEGIN VERIFY SCRIPT- sed --in-place'' --expression='s/NET_TOR/NET_ONION/g' $(git grep -I --files-with-matches 'NET_TOR') -END VERIFY SCRIPT- The --in-place'' hack is required for sed on macOS to edit files in-place without passing a backup extension.
2018-07-02 11:37:59 +02:00
BOOST_CHECK(ResolveIP("FD87:D87E:EB43:edb1:8e4:3588:e546:35ca").GetNetwork() == NET_ONION);
net: add an internal subnet for representing unresolved hostnames We currently do two resolves for dns seeds: one for the results, and one to serve in addrman as the source for those addresses. There's no requirement that the source hostname resolves to the stored identifier, only that the mapping is unique. So rather than incurring the second lookup, combine a private subnet with a hash of the hostname. The resulting v6 ip is guaranteed not to be publicy routable, and has only a negligible chance of colliding with a user's internal network (which would be of no consequence anyway).
2017-05-23 20:04:38 -04:00
BOOST_CHECK(CreateInternal("foo.com").GetNetwork() == NET_INTERNAL);
net: Split resolving out of CNetAddr
2016-05-31 13:05:52 -04:00
Add netbase tests
2012-06-08 18:42:05 +02:00
}
BOOST_AUTO_TEST_CASE(netbase_properties)
{
net: Split resolving out of CNetAddr
2016-05-31 13:05:52 -04:00
BOOST_CHECK(ResolveIP("127.0.0.1").IsIPv4());
BOOST_CHECK(ResolveIP("::FFFF:192.168.1.1").IsIPv4());
BOOST_CHECK(ResolveIP("::1").IsIPv6());
BOOST_CHECK(ResolveIP("10.0.0.1").IsRFC1918());
BOOST_CHECK(ResolveIP("192.168.1.1").IsRFC1918());
BOOST_CHECK(ResolveIP("172.31.255.255").IsRFC1918());
test: add IsRFC2544 tests
2019-12-16 19:43:15 -08:00
BOOST_CHECK(ResolveIP("198.18.0.0").IsRFC2544());
BOOST_CHECK(ResolveIP("198.19.255.255").IsRFC2544());
net: Split resolving out of CNetAddr
2016-05-31 13:05:52 -04:00
BOOST_CHECK(ResolveIP("2001:0DB8::").IsRFC3849());
BOOST_CHECK(ResolveIP("169.254.1.1").IsRFC3927());
BOOST_CHECK(ResolveIP("2002::1").IsRFC3964());
BOOST_CHECK(ResolveIP("FC00::").IsRFC4193());
BOOST_CHECK(ResolveIP("2001::2").IsRFC4380());
BOOST_CHECK(ResolveIP("2001:10::").IsRFC4843());
netaddress: Update CNetAddr for ORCHIDv2 The original ORCHID prefix was deprecated as of 2014-03, the new ORCHIDv2 prefix was allocated by RFC7343 as of 2014-07. We did not consider the original ORCHID prefix routable, and I don't see any reason to consider the new one to be either.
2019-03-28 15:21:31 -04:00
BOOST_CHECK(ResolveIP("2001:20::").IsRFC7343());
net: Split resolving out of CNetAddr
2016-05-31 13:05:52 -04:00
BOOST_CHECK(ResolveIP("FE80::").IsRFC4862());
BOOST_CHECK(ResolveIP("64:FF9B::").IsRFC6052());
BOOST_CHECK(ResolveIP("FD87:D87E:EB43:edb1:8e4:3588:e546:35ca").IsTor());
BOOST_CHECK(ResolveIP("127.0.0.1").IsLocal());
BOOST_CHECK(ResolveIP("::1").IsLocal());
BOOST_CHECK(ResolveIP("8.8.8.8").IsRoutable());
BOOST_CHECK(ResolveIP("2001::1").IsRoutable());
BOOST_CHECK(ResolveIP("127.0.0.1").IsValid());
net: add an internal subnet for representing unresolved hostnames We currently do two resolves for dns seeds: one for the results, and one to serve in addrman as the source for those addresses. There's no requirement that the source hostname resolves to the stored identifier, only that the mapping is unique. So rather than incurring the second lookup, combine a private subnet with a hash of the hostname. The resulting v6 ip is guaranteed not to be publicy routable, and has only a negligible chance of colliding with a user's internal network (which would be of no consequence anyway).
2017-05-23 20:04:38 -04:00
BOOST_CHECK(CreateInternal("FD6B:88C0:8724:edb1:8e4:3588:e546:35ca").IsInternal());
BOOST_CHECK(CreateInternal("bar.com").IsInternal());
net: Split resolving out of CNetAddr
2016-05-31 13:05:52 -04:00
Add netbase tests
2012-06-08 18:42:05 +02:00
}
p2p, refactor: pass and use uint16_t CService::port as uint16_t
2021-03-01 21:35:28 +01:00
bool static TestSplitHost(const std::string& test, const std::string& host, uint16_t port)
Add netbase tests
2012-06-08 18:42:05 +02:00
{
Refactoring: Removed using namespace <xxx> from bench/ and test/ source files.
2016-12-05 16:03:53 +09:00
std::string hostOut;
p2p, refactor: pass and use uint16_t CService::port as uint16_t
2021-03-01 21:35:28 +01:00
uint16_t portOut{0};
Add netbase tests
2012-06-08 18:42:05 +02:00
SplitHostPort(test, portOut, hostOut);
return hostOut == host && port == portOut;
}
BOOST_AUTO_TEST_CASE(netbase_splithost)
{
p2p, refactor: pass and use uint16_t CService::port as uint16_t
2021-03-01 21:35:28 +01:00
BOOST_CHECK(TestSplitHost("www.bitcoincore.org", "www.bitcoincore.org", 0));
BOOST_CHECK(TestSplitHost("[www.bitcoincore.org]", "www.bitcoincore.org", 0));
doc: Adjust bitcoincore.org links
2018-07-22 10:43:57 -04:00
BOOST_CHECK(TestSplitHost("www.bitcoincore.org:80", "www.bitcoincore.org", 80));
BOOST_CHECK(TestSplitHost("[www.bitcoincore.org]:80", "www.bitcoincore.org", 80));
p2p, refactor: pass and use uint16_t CService::port as uint16_t
2021-03-01 21:35:28 +01:00
BOOST_CHECK(TestSplitHost("127.0.0.1", "127.0.0.1", 0));
Add netbase tests
2012-06-08 18:42:05 +02:00
BOOST_CHECK(TestSplitHost("127.0.0.1:8333", "127.0.0.1", 8333));
p2p, refactor: pass and use uint16_t CService::port as uint16_t
2021-03-01 21:35:28 +01:00
BOOST_CHECK(TestSplitHost("[127.0.0.1]", "127.0.0.1", 0));
Add netbase tests
2012-06-08 18:42:05 +02:00
BOOST_CHECK(TestSplitHost("[127.0.0.1]:8333", "127.0.0.1", 8333));
p2p, refactor: pass and use uint16_t CService::port as uint16_t
2021-03-01 21:35:28 +01:00
BOOST_CHECK(TestSplitHost("::ffff:127.0.0.1", "::ffff:127.0.0.1", 0));
Add netbase tests
2012-06-08 18:42:05 +02:00
BOOST_CHECK(TestSplitHost("[::ffff:127.0.0.1]:8333", "::ffff:127.0.0.1", 8333));
BOOST_CHECK(TestSplitHost("[::]:8333", "::", 8333));
p2p, refactor: pass and use uint16_t CService::port as uint16_t
2021-03-01 21:35:28 +01:00
BOOST_CHECK(TestSplitHost("::8333", "::8333", 0));
Add netbase tests
2012-06-08 18:42:05 +02:00
BOOST_CHECK(TestSplitHost(":8333", "", 8333));
BOOST_CHECK(TestSplitHost("[]:8333", "", 8333));
p2p, refactor: pass and use uint16_t CService::port as uint16_t
2021-03-01 21:35:28 +01:00
BOOST_CHECK(TestSplitHost("", "", 0));
Add netbase tests
2012-06-08 18:42:05 +02:00
}
Refactoring: Removed using namespace <xxx> from bench/ and test/ source files.
2016-12-05 16:03:53 +09:00
bool static TestParse(std::string src, std::string canon)
Add netbase tests
2012-06-08 18:42:05 +02:00
{
net: Avoid using C-style NUL-terminated strings as arguments in the netbase interface
2019-12-11 16:39:29 +00:00
CService addr(LookupNumeric(src, 65535));
Add netbase tests
2012-06-08 18:42:05 +02:00
return canon == addr.ToString();
}
BOOST_AUTO_TEST_CASE(netbase_lookupnumeric)
{
BOOST_CHECK(TestParse("127.0.0.1", "127.0.0.1:65535"));
BOOST_CHECK(TestParse("127.0.0.1:8333", "127.0.0.1:8333"));
BOOST_CHECK(TestParse("::ffff:127.0.0.1", "127.0.0.1:65535"));
BOOST_CHECK(TestParse("::", "[::]:65535"));
BOOST_CHECK(TestParse("[::]:8333", "[::]:8333"));
BOOST_CHECK(TestParse("[127.0.0.1]", "127.0.0.1:65535"));
net: Have LookupNumeric return a CService directly Also fix up a few small issues: - Lookup with "badip:port" now sets the port to 0 - Don't allow assert to have side-effects
2016-08-04 16:37:49 -04:00
BOOST_CHECK(TestParse(":::", "[::]:0"));
net: do not allow resolving to an internal address In order to prevent mixups, our internal range is never allowed as a resolve result. This means that no user-provided string will ever be confused with an internal address.
2017-06-13 17:26:50 -04:00
// verify that an internal address fails to resolve
BOOST_CHECK(TestParse("[fd6b:88c0:8724:1:2:3:4:5]", "[::]:0"));
// and that a one-off resolves correctly
BOOST_CHECK(TestParse("[fd6c:88c0:8724:1:2:3:4:5]", "[fd6c:88c0:8724:1:2:3:4:5]:65535"));
Add netbase tests
2012-06-08 18:42:05 +02:00
}
Node support for Tor hidden services This commit adds support for .onion addresses (mapped into the IPv6 by using OnionCat's range and encoding), and the ability to connect to them via a SOCKS5 proxy.
2012-04-29 02:11:56 +02:00
BOOST_AUTO_TEST_CASE(onioncat_test)
{
Update moved and dead links
2014-03-24 20:26:02 +00:00
// values from https://web.archive.org/web/20121122003543/http://www.cypherpunk.at/onioncat/wiki/OnionCat
net: Split resolving out of CNetAddr
2016-05-31 13:05:52 -04:00
CNetAddr addr1(ResolveIP("5wyqrzbvrdsumnok.onion"));
CNetAddr addr2(ResolveIP("FD87:D87E:EB43:edb1:8e4:3588:e546:35ca"));
Node support for Tor hidden services This commit adds support for .onion addresses (mapped into the IPv6 by using OnionCat's range and encoding), and the ability to connect to them via a SOCKS5 proxy.
2012-04-29 02:11:56 +02:00
BOOST_CHECK(addr1 == addr2);
BOOST_CHECK(addr1.IsTor());
BOOST_CHECK(addr1.ToStringIP() == "5wyqrzbvrdsumnok.onion");
BOOST_CHECK(addr1.IsRoutable());
net: Split resolving out of CNetAddr
2016-05-31 13:05:52 -04:00
Node support for Tor hidden services This commit adds support for .onion addresses (mapped into the IPv6 by using OnionCat's range and encoding), and the ability to connect to them via a SOCKS5 proxy.
2012-04-29 02:11:56 +02:00
}
net: save the network type explicitly in CNetAddr Before this change, we would analyze the contents of `CNetAddr::ip[16]` in order to tell which type is an address. Change this by introducing a new member `CNetAddr::m_net` that explicitly tells the type of the address. This is necessary because in BIP155 we will not be able to tell the address type by just looking at its raw representation (e.g. both TORv3 and I2P are "seemingly random" 32 bytes). As a side effect of this change we no longer need to store IPv4 addresses encoded as IPv6 addresses - we can store them in proper 4 bytes (will be done in a separate commit). Also the code gets somewhat simplified - instead of `memcmp(ip, pchIPv4, sizeof(pchIPv4)) == 0` we can use `m_net == NET_IPV4`. Co-authored-by: Carl Dong <contact@carldong.me>
2020-05-14 17:03:11 +02:00
BOOST_AUTO_TEST_CASE(embedded_test)
{
CNetAddr addr1(ResolveIP("1.2.3.4"));
CNetAddr addr2(ResolveIP("::FFFF:0102:0304"));
BOOST_CHECK(addr2.IsIPv4());
BOOST_CHECK_EQUAL(addr1.ToString(), addr2.ToString());
}
net: Add CSubNet class for subnet matching
2014-04-28 11:08:57 +02:00
BOOST_AUTO_TEST_CASE(subnet_test)
{
net: Split resolving out of CNetAddr
2016-05-31 13:05:52 -04:00
net: Split resolving out of CSubNet
2016-05-31 15:50:24 -04:00
BOOST_CHECK(ResolveSubNet("1.2.3.0/24") == ResolveSubNet("1.2.3.0/255.255.255.0"));
BOOST_CHECK(ResolveSubNet("1.2.3.0/24") != ResolveSubNet("1.2.4.0/255.255.255.0"));
BOOST_CHECK(ResolveSubNet("1.2.3.0/24").Match(ResolveIP("1.2.3.4")));
BOOST_CHECK(!ResolveSubNet("1.2.2.0/24").Match(ResolveIP("1.2.3.4")));
BOOST_CHECK(ResolveSubNet("1.2.3.4").Match(ResolveIP("1.2.3.4")));
BOOST_CHECK(ResolveSubNet("1.2.3.4/32").Match(ResolveIP("1.2.3.4")));
BOOST_CHECK(!ResolveSubNet("1.2.3.4").Match(ResolveIP("5.6.7.8")));
BOOST_CHECK(!ResolveSubNet("1.2.3.4/32").Match(ResolveIP("5.6.7.8")));
BOOST_CHECK(ResolveSubNet("::ffff:127.0.0.1").Match(ResolveIP("127.0.0.1")));
BOOST_CHECK(ResolveSubNet("1:2:3:4:5:6:7:8").Match(ResolveIP("1:2:3:4:5:6:7:8")));
BOOST_CHECK(!ResolveSubNet("1:2:3:4:5:6:7:8").Match(ResolveIP("1:2:3:4:5:6:7:9")));
BOOST_CHECK(ResolveSubNet("1:2:3:4:5:6:7:0/112").Match(ResolveIP("1:2:3:4:5:6:7:1234")));
BOOST_CHECK(ResolveSubNet("192.168.0.1/24").Match(ResolveIP("192.168.0.2")));
BOOST_CHECK(ResolveSubNet("192.168.0.20/29").Match(ResolveIP("192.168.0.18")));
BOOST_CHECK(ResolveSubNet("1.2.2.1/24").Match(ResolveIP("1.2.2.4")));
BOOST_CHECK(ResolveSubNet("1.2.2.110/31").Match(ResolveIP("1.2.2.111")));
BOOST_CHECK(ResolveSubNet("1.2.2.20/26").Match(ResolveIP("1.2.2.63")));
net: save the network type explicitly in CNetAddr Before this change, we would analyze the contents of `CNetAddr::ip[16]` in order to tell which type is an address. Change this by introducing a new member `CNetAddr::m_net` that explicitly tells the type of the address. This is necessary because in BIP155 we will not be able to tell the address type by just looking at its raw representation (e.g. both TORv3 and I2P are "seemingly random" 32 bytes). As a side effect of this change we no longer need to store IPv4 addresses encoded as IPv6 addresses - we can store them in proper 4 bytes (will be done in a separate commit). Also the code gets somewhat simplified - instead of `memcmp(ip, pchIPv4, sizeof(pchIPv4)) == 0` we can use `m_net == NET_IPV4`. Co-authored-by: Carl Dong <contact@carldong.me>
2020-05-14 17:03:11 +02:00
// All-Matching IPv6 Matches arbitrary IPv6
net: Split resolving out of CSubNet
2016-05-31 15:50:24 -04:00
BOOST_CHECK(ResolveSubNet("::/0").Match(ResolveIP("1:2:3:4:5:6:7:1234")));
test: add two edge case tests for CSubNet
2020-05-15 17:02:05 +02:00
// But not `::` or `0.0.0.0` because they are considered invalid addresses
BOOST_CHECK(!ResolveSubNet("::/0").Match(ResolveIP("::")));
BOOST_CHECK(!ResolveSubNet("::/0").Match(ResolveIP("0.0.0.0")));
net: save the network type explicitly in CNetAddr Before this change, we would analyze the contents of `CNetAddr::ip[16]` in order to tell which type is an address. Change this by introducing a new member `CNetAddr::m_net` that explicitly tells the type of the address. This is necessary because in BIP155 we will not be able to tell the address type by just looking at its raw representation (e.g. both TORv3 and I2P are "seemingly random" 32 bytes). As a side effect of this change we no longer need to store IPv4 addresses encoded as IPv6 addresses - we can store them in proper 4 bytes (will be done in a separate commit). Also the code gets somewhat simplified - instead of `memcmp(ip, pchIPv4, sizeof(pchIPv4)) == 0` we can use `m_net == NET_IPV4`. Co-authored-by: Carl Dong <contact@carldong.me>
2020-05-14 17:03:11 +02:00
// Addresses from one network (IPv4) don't belong to subnets of another network (IPv6)
BOOST_CHECK(!ResolveSubNet("::/0").Match(ResolveIP("1.2.3.4")));
net: Add CSubNet class for subnet matching
2014-04-28 11:08:57 +02:00
// All-Matching IPv4 does not Match IPv6
net: Split resolving out of CSubNet
2016-05-31 15:50:24 -04:00
BOOST_CHECK(!ResolveSubNet("0.0.0.0/0").Match(ResolveIP("1:2:3:4:5:6:7:1234")));
net: Add CSubNet class for subnet matching
2014-04-28 11:08:57 +02:00
// Invalid subnets Match nothing (not even invalid addresses)
net: Split resolving out of CNetAddr
2016-05-31 13:05:52 -04:00
BOOST_CHECK(!CSubNet().Match(ResolveIP("1.2.3.4")));
net: Split resolving out of CSubNet
2016-05-31 15:50:24 -04:00
BOOST_CHECK(!ResolveSubNet("").Match(ResolveIP("4.5.6.7")));
BOOST_CHECK(!ResolveSubNet("bloop").Match(ResolveIP("0.0.0.0")));
BOOST_CHECK(!ResolveSubNet("bloop").Match(ResolveIP("hab")));
net: Add CSubNet class for subnet matching
2014-04-28 11:08:57 +02:00
// Check valid/invalid
net: Split resolving out of CSubNet
2016-05-31 15:50:24 -04:00
BOOST_CHECK(ResolveSubNet("1.2.3.0/0").IsValid());
BOOST_CHECK(!ResolveSubNet("1.2.3.0/-1").IsValid());
BOOST_CHECK(ResolveSubNet("1.2.3.0/32").IsValid());
BOOST_CHECK(!ResolveSubNet("1.2.3.0/33").IsValid());
net: change CNetAddr::ip to have flexible size Before this change `CNetAddr::ip` was a fixed-size array of 16 bytes, not being able to store larger addresses (e.g. TORv3) and encoded smaller ones as 16-byte IPv6 addresses. Change its type to `prevector`, so that it can hold larger addresses and do not disguise non-IPv6 addresses as IPv6. So the IPv4 address `1.2.3.4` is now encoded as `01020304` instead of `00000000000000000000FFFF01020304`. Rename `CNetAddr::ip` to `CNetAddr::m_addr` because it is not an "IP" or "IP address" (TOR addresses are not IP addresses). In order to preserve backward compatibility with serialization (where e.g. `1.2.3.4` is serialized as `00000000000000000000FFFF01020304`) introduce `CNetAddr` dedicated legacy serialize/unserialize methods. Adjust `CSubNet` accordingly. Still use `CSubNet::netmask[]` of fixed 16 bytes, but use the first 4 for IPv4 (not the last 4). Only allow subnetting for IPv4 and IPv6. Co-authored-by: Carl Dong <contact@carldong.me>
2020-08-24 21:34:26 +02:00
BOOST_CHECK(!ResolveSubNet("1.2.3.0/300").IsValid());
net: Split resolving out of CSubNet
2016-05-31 15:50:24 -04:00
BOOST_CHECK(ResolveSubNet("1:2:3:4:5:6:7:8/0").IsValid());
BOOST_CHECK(ResolveSubNet("1:2:3:4:5:6:7:8/33").IsValid());
BOOST_CHECK(!ResolveSubNet("1:2:3:4:5:6:7:8/-1").IsValid());
BOOST_CHECK(ResolveSubNet("1:2:3:4:5:6:7:8/128").IsValid());
BOOST_CHECK(!ResolveSubNet("1:2:3:4:5:6:7:8/129").IsValid());
BOOST_CHECK(!ResolveSubNet("fuzzy").IsValid());
Adding CSubNet constructor over a single CNetAddr
2015-06-29 20:37:22 +02:00
//CNetAddr constructor test
net: Split resolving out of CNetAddr
2016-05-31 13:05:52 -04:00
BOOST_CHECK(CSubNet(ResolveIP("127.0.0.1")).IsValid());
BOOST_CHECK(CSubNet(ResolveIP("127.0.0.1")).Match(ResolveIP("127.0.0.1")));
BOOST_CHECK(!CSubNet(ResolveIP("127.0.0.1")).Match(ResolveIP("127.0.0.2")));
BOOST_CHECK(CSubNet(ResolveIP("127.0.0.1")).ToString() == "127.0.0.1/32");
Adding CSubNet constructor over a single CNetAddr
2015-06-29 20:37:22 +02:00
net: Add direct tests for new CSubNet constructors
2016-05-31 18:18:41 -04:00
CSubNet subnet = CSubNet(ResolveIP("1.2.3.4"), 32);
BOOST_CHECK_EQUAL(subnet.ToString(), "1.2.3.4/32");
subnet = CSubNet(ResolveIP("1.2.3.4"), 8);
BOOST_CHECK_EQUAL(subnet.ToString(), "1.0.0.0/8");
subnet = CSubNet(ResolveIP("1.2.3.4"), 0);
BOOST_CHECK_EQUAL(subnet.ToString(), "0.0.0.0/0");
subnet = CSubNet(ResolveIP("1.2.3.4"), ResolveIP("255.255.255.255"));
BOOST_CHECK_EQUAL(subnet.ToString(), "1.2.3.4/32");
subnet = CSubNet(ResolveIP("1.2.3.4"), ResolveIP("255.0.0.0"));
BOOST_CHECK_EQUAL(subnet.ToString(), "1.0.0.0/8");
subnet = CSubNet(ResolveIP("1.2.3.4"), ResolveIP("0.0.0.0"));
BOOST_CHECK_EQUAL(subnet.ToString(), "0.0.0.0/0");
net: Split resolving out of CNetAddr
2016-05-31 13:05:52 -04:00
BOOST_CHECK(CSubNet(ResolveIP("1:2:3:4:5:6:7:8")).IsValid());
BOOST_CHECK(CSubNet(ResolveIP("1:2:3:4:5:6:7:8")).Match(ResolveIP("1:2:3:4:5:6:7:8")));
BOOST_CHECK(!CSubNet(ResolveIP("1:2:3:4:5:6:7:8")).Match(ResolveIP("1:2:3:4:5:6:7:9")));
BOOST_CHECK(CSubNet(ResolveIP("1:2:3:4:5:6:7:8")).ToString() == "1:2:3:4:5:6:7:8/128");
net: change CNetAddr::ip to have flexible size Before this change `CNetAddr::ip` was a fixed-size array of 16 bytes, not being able to store larger addresses (e.g. TORv3) and encoded smaller ones as 16-byte IPv6 addresses. Change its type to `prevector`, so that it can hold larger addresses and do not disguise non-IPv6 addresses as IPv6. So the IPv4 address `1.2.3.4` is now encoded as `01020304` instead of `00000000000000000000FFFF01020304`. Rename `CNetAddr::ip` to `CNetAddr::m_addr` because it is not an "IP" or "IP address" (TOR addresses are not IP addresses). In order to preserve backward compatibility with serialization (where e.g. `1.2.3.4` is serialized as `00000000000000000000FFFF01020304`) introduce `CNetAddr` dedicated legacy serialize/unserialize methods. Adjust `CSubNet` accordingly. Still use `CSubNet::netmask[]` of fixed 16 bytes, but use the first 4 for IPv4 (not the last 4). Only allow subnetting for IPv4 and IPv6. Co-authored-by: Carl Dong <contact@carldong.me>
2020-08-24 21:34:26 +02:00
// IPv4 address with IPv6 netmask or the other way around.
BOOST_CHECK(!CSubNet(ResolveIP("1.1.1.1"), ResolveIP("ffff::")).IsValid());
BOOST_CHECK(!CSubNet(ResolveIP("::1"), ResolveIP("255.0.0.0")).IsValid());
net: allow CSubNet of non-IP networks Allow creation of valid `CSubNet` objects of non-IP networks and only match the single address they were created from (like /32 for IPv4 or /128 for IPv6). This fixes a deficiency in `CConnman::DisconnectNode(const CNetAddr& addr)` and in `BanMan` which assume that creating a subnet from any address using the `CSubNet(CNetAddr)` constructor would later match that address only. Before this change a non-IP subnet would be invalid and would not match any address.
2021-01-04 18:37:52 +01:00
// Create Non-IP subnets.
const CNetAddr tor_addr{
ResolveIP("pg6mmjiyjmcrsslvykfwnntlaru7p5svn6y2ymmju6nubxndf4pscryd.onion")};
subnet = CSubNet(tor_addr);
BOOST_CHECK(subnet.IsValid());
BOOST_CHECK_EQUAL(subnet.ToString(), tor_addr.ToString());
BOOST_CHECK(subnet.Match(tor_addr));
BOOST_CHECK(
!subnet.Match(ResolveIP("kpgvmscirrdqpekbqjsvw5teanhatztpp2gl6eee4zkowvwfxwenqaid.onion")));
BOOST_CHECK(!subnet.Match(ResolveIP("1.2.3.4")));
BOOST_CHECK(!CSubNet(tor_addr, 200).IsValid());
BOOST_CHECK(!CSubNet(tor_addr, ResolveIP("255.0.0.0")).IsValid());
net: use CIDR notation in CSubNet::ToString()
2015-06-23 17:20:00 +02:00
net: Add direct tests for new CSubNet constructors
2016-05-31 18:18:41 -04:00
subnet = ResolveSubNet("1.2.3.4/255.255.255.255");
net: use CIDR notation in CSubNet::ToString()
2015-06-23 17:20:00 +02:00
BOOST_CHECK_EQUAL(subnet.ToString(), "1.2.3.4/32");
net: Split resolving out of CSubNet
2016-05-31 15:50:24 -04:00
subnet = ResolveSubNet("1.2.3.4/255.255.255.254");
net: use CIDR notation in CSubNet::ToString()
2015-06-23 17:20:00 +02:00
BOOST_CHECK_EQUAL(subnet.ToString(), "1.2.3.4/31");
net: Split resolving out of CSubNet
2016-05-31 15:50:24 -04:00
subnet = ResolveSubNet("1.2.3.4/255.255.255.252");
net: use CIDR notation in CSubNet::ToString()
2015-06-23 17:20:00 +02:00
BOOST_CHECK_EQUAL(subnet.ToString(), "1.2.3.4/30");
net: Split resolving out of CSubNet
2016-05-31 15:50:24 -04:00
subnet = ResolveSubNet("1.2.3.4/255.255.255.248");
net: use CIDR notation in CSubNet::ToString()
2015-06-23 17:20:00 +02:00
BOOST_CHECK_EQUAL(subnet.ToString(), "1.2.3.0/29");
net: Split resolving out of CSubNet
2016-05-31 15:50:24 -04:00
subnet = ResolveSubNet("1.2.3.4/255.255.255.240");
net: use CIDR notation in CSubNet::ToString()
2015-06-23 17:20:00 +02:00
BOOST_CHECK_EQUAL(subnet.ToString(), "1.2.3.0/28");
net: Split resolving out of CSubNet
2016-05-31 15:50:24 -04:00
subnet = ResolveSubNet("1.2.3.4/255.255.255.224");
net: use CIDR notation in CSubNet::ToString()
2015-06-23 17:20:00 +02:00
BOOST_CHECK_EQUAL(subnet.ToString(), "1.2.3.0/27");
net: Split resolving out of CSubNet
2016-05-31 15:50:24 -04:00
subnet = ResolveSubNet("1.2.3.4/255.255.255.192");
net: use CIDR notation in CSubNet::ToString()
2015-06-23 17:20:00 +02:00
BOOST_CHECK_EQUAL(subnet.ToString(), "1.2.3.0/26");
net: Split resolving out of CSubNet
2016-05-31 15:50:24 -04:00
subnet = ResolveSubNet("1.2.3.4/255.255.255.128");
net: use CIDR notation in CSubNet::ToString()
2015-06-23 17:20:00 +02:00
BOOST_CHECK_EQUAL(subnet.ToString(), "1.2.3.0/25");
net: Split resolving out of CSubNet
2016-05-31 15:50:24 -04:00
subnet = ResolveSubNet("1.2.3.4/255.255.255.0");
net: use CIDR notation in CSubNet::ToString()
2015-06-23 17:20:00 +02:00
BOOST_CHECK_EQUAL(subnet.ToString(), "1.2.3.0/24");
net: Split resolving out of CSubNet
2016-05-31 15:50:24 -04:00
subnet = ResolveSubNet("1.2.3.4/255.255.254.0");
net: use CIDR notation in CSubNet::ToString()
2015-06-23 17:20:00 +02:00
BOOST_CHECK_EQUAL(subnet.ToString(), "1.2.2.0/23");
net: Split resolving out of CSubNet
2016-05-31 15:50:24 -04:00
subnet = ResolveSubNet("1.2.3.4/255.255.252.0");
net: use CIDR notation in CSubNet::ToString()
2015-06-23 17:20:00 +02:00
BOOST_CHECK_EQUAL(subnet.ToString(), "1.2.0.0/22");
net: Split resolving out of CSubNet
2016-05-31 15:50:24 -04:00
subnet = ResolveSubNet("1.2.3.4/255.255.248.0");
net: use CIDR notation in CSubNet::ToString()
2015-06-23 17:20:00 +02:00
BOOST_CHECK_EQUAL(subnet.ToString(), "1.2.0.0/21");
net: Split resolving out of CSubNet
2016-05-31 15:50:24 -04:00
subnet = ResolveSubNet("1.2.3.4/255.255.240.0");
net: use CIDR notation in CSubNet::ToString()
2015-06-23 17:20:00 +02:00
BOOST_CHECK_EQUAL(subnet.ToString(), "1.2.0.0/20");
net: Split resolving out of CSubNet
2016-05-31 15:50:24 -04:00
subnet = ResolveSubNet("1.2.3.4/255.255.224.0");
net: use CIDR notation in CSubNet::ToString()
2015-06-23 17:20:00 +02:00
BOOST_CHECK_EQUAL(subnet.ToString(), "1.2.0.0/19");
net: Split resolving out of CSubNet
2016-05-31 15:50:24 -04:00
subnet = ResolveSubNet("1.2.3.4/255.255.192.0");
net: use CIDR notation in CSubNet::ToString()
2015-06-23 17:20:00 +02:00
BOOST_CHECK_EQUAL(subnet.ToString(), "1.2.0.0/18");
net: Split resolving out of CSubNet
2016-05-31 15:50:24 -04:00
subnet = ResolveSubNet("1.2.3.4/255.255.128.0");
net: use CIDR notation in CSubNet::ToString()
2015-06-23 17:20:00 +02:00
BOOST_CHECK_EQUAL(subnet.ToString(), "1.2.0.0/17");
net: Split resolving out of CSubNet
2016-05-31 15:50:24 -04:00
subnet = ResolveSubNet("1.2.3.4/255.255.0.0");
net: use CIDR notation in CSubNet::ToString()
2015-06-23 17:20:00 +02:00
BOOST_CHECK_EQUAL(subnet.ToString(), "1.2.0.0/16");
net: Split resolving out of CSubNet
2016-05-31 15:50:24 -04:00
subnet = ResolveSubNet("1.2.3.4/255.254.0.0");
net: use CIDR notation in CSubNet::ToString()
2015-06-23 17:20:00 +02:00
BOOST_CHECK_EQUAL(subnet.ToString(), "1.2.0.0/15");
net: Split resolving out of CSubNet
2016-05-31 15:50:24 -04:00
subnet = ResolveSubNet("1.2.3.4/255.252.0.0");
net: use CIDR notation in CSubNet::ToString()
2015-06-23 17:20:00 +02:00
BOOST_CHECK_EQUAL(subnet.ToString(), "1.0.0.0/14");
net: Split resolving out of CSubNet
2016-05-31 15:50:24 -04:00
subnet = ResolveSubNet("1.2.3.4/255.248.0.0");
net: use CIDR notation in CSubNet::ToString()
2015-06-23 17:20:00 +02:00
BOOST_CHECK_EQUAL(subnet.ToString(), "1.0.0.0/13");
net: Split resolving out of CSubNet
2016-05-31 15:50:24 -04:00
subnet = ResolveSubNet("1.2.3.4/255.240.0.0");
net: use CIDR notation in CSubNet::ToString()
2015-06-23 17:20:00 +02:00
BOOST_CHECK_EQUAL(subnet.ToString(), "1.0.0.0/12");
net: Split resolving out of CSubNet
2016-05-31 15:50:24 -04:00
subnet = ResolveSubNet("1.2.3.4/255.224.0.0");
net: use CIDR notation in CSubNet::ToString()
2015-06-23 17:20:00 +02:00
BOOST_CHECK_EQUAL(subnet.ToString(), "1.0.0.0/11");
net: Split resolving out of CSubNet
2016-05-31 15:50:24 -04:00
subnet = ResolveSubNet("1.2.3.4/255.192.0.0");
net: use CIDR notation in CSubNet::ToString()
2015-06-23 17:20:00 +02:00
BOOST_CHECK_EQUAL(subnet.ToString(), "1.0.0.0/10");
net: Split resolving out of CSubNet
2016-05-31 15:50:24 -04:00
subnet = ResolveSubNet("1.2.3.4/255.128.0.0");
net: use CIDR notation in CSubNet::ToString()
2015-06-23 17:20:00 +02:00
BOOST_CHECK_EQUAL(subnet.ToString(), "1.0.0.0/9");
net: Split resolving out of CSubNet
2016-05-31 15:50:24 -04:00
subnet = ResolveSubNet("1.2.3.4/255.0.0.0");
net: use CIDR notation in CSubNet::ToString()
2015-06-23 17:20:00 +02:00
BOOST_CHECK_EQUAL(subnet.ToString(), "1.0.0.0/8");
net: Split resolving out of CSubNet
2016-05-31 15:50:24 -04:00
subnet = ResolveSubNet("1.2.3.4/254.0.0.0");
net: use CIDR notation in CSubNet::ToString()
2015-06-23 17:20:00 +02:00
BOOST_CHECK_EQUAL(subnet.ToString(), "0.0.0.0/7");
net: Split resolving out of CSubNet
2016-05-31 15:50:24 -04:00
subnet = ResolveSubNet("1.2.3.4/252.0.0.0");
net: use CIDR notation in CSubNet::ToString()
2015-06-23 17:20:00 +02:00
BOOST_CHECK_EQUAL(subnet.ToString(), "0.0.0.0/6");
net: Split resolving out of CSubNet
2016-05-31 15:50:24 -04:00
subnet = ResolveSubNet("1.2.3.4/248.0.0.0");
net: use CIDR notation in CSubNet::ToString()
2015-06-23 17:20:00 +02:00
BOOST_CHECK_EQUAL(subnet.ToString(), "0.0.0.0/5");
net: Split resolving out of CSubNet
2016-05-31 15:50:24 -04:00
subnet = ResolveSubNet("1.2.3.4/240.0.0.0");
net: use CIDR notation in CSubNet::ToString()
2015-06-23 17:20:00 +02:00
BOOST_CHECK_EQUAL(subnet.ToString(), "0.0.0.0/4");
net: Split resolving out of CSubNet
2016-05-31 15:50:24 -04:00
subnet = ResolveSubNet("1.2.3.4/224.0.0.0");
net: use CIDR notation in CSubNet::ToString()
2015-06-23 17:20:00 +02:00
BOOST_CHECK_EQUAL(subnet.ToString(), "0.0.0.0/3");
net: Split resolving out of CSubNet
2016-05-31 15:50:24 -04:00
subnet = ResolveSubNet("1.2.3.4/192.0.0.0");
net: use CIDR notation in CSubNet::ToString()
2015-06-23 17:20:00 +02:00
BOOST_CHECK_EQUAL(subnet.ToString(), "0.0.0.0/2");
net: Split resolving out of CSubNet
2016-05-31 15:50:24 -04:00
subnet = ResolveSubNet("1.2.3.4/128.0.0.0");
net: use CIDR notation in CSubNet::ToString()
2015-06-23 17:20:00 +02:00
BOOST_CHECK_EQUAL(subnet.ToString(), "0.0.0.0/1");
net: Split resolving out of CSubNet
2016-05-31 15:50:24 -04:00
subnet = ResolveSubNet("1.2.3.4/0.0.0.0");
net: use CIDR notation in CSubNet::ToString()
2015-06-23 17:20:00 +02:00
BOOST_CHECK_EQUAL(subnet.ToString(), "0.0.0.0/0");
net: Split resolving out of CSubNet
2016-05-31 15:50:24 -04:00
subnet = ResolveSubNet("1:2:3:4:5:6:7:8/ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff");
net: use CIDR notation in CSubNet::ToString()
2015-06-23 17:20:00 +02:00
BOOST_CHECK_EQUAL(subnet.ToString(), "1:2:3:4:5:6:7:8/128");
net: Split resolving out of CSubNet
2016-05-31 15:50:24 -04:00
subnet = ResolveSubNet("1:2:3:4:5:6:7:8/ffff:0000:0000:0000:0000:0000:0000:0000");
net: use CIDR notation in CSubNet::ToString()
2015-06-23 17:20:00 +02:00
BOOST_CHECK_EQUAL(subnet.ToString(), "1::/16");
net: Split resolving out of CSubNet
2016-05-31 15:50:24 -04:00
subnet = ResolveSubNet("1:2:3:4:5:6:7:8/0000:0000:0000:0000:0000:0000:0000:0000");
net: use CIDR notation in CSubNet::ToString()
2015-06-23 17:20:00 +02:00
BOOST_CHECK_EQUAL(subnet.ToString(), "::/0");
net: don't accept non-left-contiguous netmasks A netmask that contains 1-bits after 0-bits (the 1-bits are not contiguous on the left side) is invalid [1] [2]. The code before this PR used to parse and accept such non-left-contiguous netmasks. However, a coming change that will alter `CNetAddr::ip` to have flexible size would make juggling with such netmasks more difficult, thus drop support for those. [1] https://en.wikipedia.org/wiki/Classless_Inter-Domain_Routing#Subnet_masks [2] https://tools.ietf.org/html/rfc4632#section-5.1
2020-08-24 21:03:31 +02:00
// Invalid netmasks (with 1-bits after 0-bits)
net: Split resolving out of CSubNet
2016-05-31 15:50:24 -04:00
subnet = ResolveSubNet("1.2.3.4/255.255.232.0");
net: don't accept non-left-contiguous netmasks A netmask that contains 1-bits after 0-bits (the 1-bits are not contiguous on the left side) is invalid [1] [2]. The code before this PR used to parse and accept such non-left-contiguous netmasks. However, a coming change that will alter `CNetAddr::ip` to have flexible size would make juggling with such netmasks more difficult, thus drop support for those. [1] https://en.wikipedia.org/wiki/Classless_Inter-Domain_Routing#Subnet_masks [2] https://tools.ietf.org/html/rfc4632#section-5.1
2020-08-24 21:03:31 +02:00
BOOST_CHECK(!subnet.IsValid());
subnet = ResolveSubNet("1.2.3.4/255.0.255.255");
BOOST_CHECK(!subnet.IsValid());
net: Split resolving out of CSubNet
2016-05-31 15:50:24 -04:00
subnet = ResolveSubNet("1:2:3:4:5:6:7:8/ffff:ffff:ffff:fffe:ffff:ffff:ffff:ff0f");
net: don't accept non-left-contiguous netmasks A netmask that contains 1-bits after 0-bits (the 1-bits are not contiguous on the left side) is invalid [1] [2]. The code before this PR used to parse and accept such non-left-contiguous netmasks. However, a coming change that will alter `CNetAddr::ip` to have flexible size would make juggling with such netmasks more difficult, thus drop support for those. [1] https://en.wikipedia.org/wiki/Classless_Inter-Domain_Routing#Subnet_masks [2] https://tools.ietf.org/html/rfc4632#section-5.1
2020-08-24 21:03:31 +02:00
BOOST_CHECK(!subnet.IsValid());
net: Add CSubNet class for subnet matching
2014-04-28 11:08:57 +02:00
}
add unit test for CNetAddr::GetGroup.
2015-08-19 14:34:56 -04:00
BOOST_AUTO_TEST_CASE(netbase_getgroup)
{
Integrate ASN bucketing in Addrman and add tests Instead of using /16 netgroups to bucket nodes in Addrman for connection diversification, ASN, which better represents an actor in terms of network-layer infrastructure, is used. For testing, asmap.raw is used. It represents a minimal asmap needed for testing purposes.
2019-12-24 13:18:44 -05:00
std::vector<bool> asmap; // use /16
BOOST_CHECK(ResolveIP("127.0.0.1").GetGroup(asmap) == std::vector<unsigned char>({0})); // Local -> !Routable()
BOOST_CHECK(ResolveIP("257.0.0.1").GetGroup(asmap) == std::vector<unsigned char>({0})); // !Valid -> !Routable()
BOOST_CHECK(ResolveIP("10.0.0.1").GetGroup(asmap) == std::vector<unsigned char>({0})); // RFC1918 -> !Routable()
BOOST_CHECK(ResolveIP("169.254.1.1").GetGroup(asmap) == std::vector<unsigned char>({0})); // RFC3927 -> !Routable()
BOOST_CHECK(ResolveIP("1.2.3.4").GetGroup(asmap) == std::vector<unsigned char>({(unsigned char)NET_IPV4, 1, 2})); // IPv4
BOOST_CHECK(ResolveIP("::FFFF:0:102:304").GetGroup(asmap) == std::vector<unsigned char>({(unsigned char)NET_IPV4, 1, 2})); // RFC6145
BOOST_CHECK(ResolveIP("64:FF9B::102:304").GetGroup(asmap) == std::vector<unsigned char>({(unsigned char)NET_IPV4, 1, 2})); // RFC6052
BOOST_CHECK(ResolveIP("2002:102:304:9999:9999:9999:9999:9999").GetGroup(asmap) == std::vector<unsigned char>({(unsigned char)NET_IPV4, 1, 2})); // RFC3964
BOOST_CHECK(ResolveIP("2001:0:9999:9999:9999:9999:FEFD:FCFB").GetGroup(asmap) == std::vector<unsigned char>({(unsigned char)NET_IPV4, 1, 2})); // RFC4380
BOOST_CHECK(ResolveIP("FD87:D87E:EB43:edb1:8e4:3588:e546:35ca").GetGroup(asmap) == std::vector<unsigned char>({(unsigned char)NET_ONION, 239})); // Tor
BOOST_CHECK(ResolveIP("2001:470:abcd:9999:9999:9999:9999:9999").GetGroup(asmap) == std::vector<unsigned char>({(unsigned char)NET_IPV6, 32, 1, 4, 112, 175})); //he.net
BOOST_CHECK(ResolveIP("2001:2001:9999:9999:9999:9999:9999:9999").GetGroup(asmap) == std::vector<unsigned char>({(unsigned char)NET_IPV6, 32, 1, 32, 1})); //IPv6
net: Split resolving out of CNetAddr
2016-05-31 13:05:52 -04:00
net: add an internal subnet for representing unresolved hostnames We currently do two resolves for dns seeds: one for the results, and one to serve in addrman as the source for those addresses. There's no requirement that the source hostname resolves to the stored identifier, only that the mapping is unique. So rather than incurring the second lookup, combine a private subnet with a hash of the hostname. The resulting v6 ip is guaranteed not to be publicy routable, and has only a negligible chance of colliding with a user's internal network (which would be of no consequence anyway).
2017-05-23 20:04:38 -04:00
// baz.net sha256 hash: 12929400eb4607c4ac075f087167e75286b179c693eb059a01774b864e8fe505
std::vector<unsigned char> internal_group = {NET_INTERNAL, 0x12, 0x92, 0x94, 0x00, 0xeb, 0x46, 0x07, 0xc4, 0xac, 0x07};
Integrate ASN bucketing in Addrman and add tests Instead of using /16 netgroups to bucket nodes in Addrman for connection diversification, ASN, which better represents an actor in terms of network-layer infrastructure, is used. For testing, asmap.raw is used. It represents a minimal asmap needed for testing purposes.
2019-12-24 13:18:44 -05:00
BOOST_CHECK(CreateInternal("baz.net").GetGroup(asmap) == internal_group);
add unit test for CNetAddr::GetGroup.
2015-08-19 14:34:56 -04:00
}
Implements ParseNetwork unit test. This commit implements a unit test that validates the `ParseNetwork(std::string)` implementation in `netbase.cpp`.
2018-07-15 21:45:30 +02:00
BOOST_AUTO_TEST_CASE(netbase_parsenetwork)
{
BOOST_CHECK_EQUAL(ParseNetwork("ipv4"), NET_IPV4);
BOOST_CHECK_EQUAL(ParseNetwork("ipv6"), NET_IPV6);
BOOST_CHECK_EQUAL(ParseNetwork("onion"), NET_ONION);
BOOST_CHECK_EQUAL(ParseNetwork("tor"), NET_ONION);
BOOST_CHECK_EQUAL(ParseNetwork("IPv4"), NET_IPV4);
BOOST_CHECK_EQUAL(ParseNetwork("IPv6"), NET_IPV6);
BOOST_CHECK_EQUAL(ParseNetwork("ONION"), NET_ONION);
BOOST_CHECK_EQUAL(ParseNetwork("TOR"), NET_ONION);
BOOST_CHECK_EQUAL(ParseNetwork(":)"), NET_UNROUTABLE);
BOOST_CHECK_EQUAL(ParseNetwork("tÖr"), NET_UNROUTABLE);
BOOST_CHECK_EQUAL(ParseNetwork("\xfe\xff"), NET_UNROUTABLE);
BOOST_CHECK_EQUAL(ParseNetwork(""), NET_UNROUTABLE);
}
Make whitebind/whitelist permissions more flexible
2019-06-20 18:37:51 +09:00
BOOST_AUTO_TEST_CASE(netpermissions_test)
{
refactor: Error message bilingual_str consistency - Move the decision whether to translate an error message to where it is defined. This simplifies call sites: no more `InitError(Untranslated(...))`. - Make all functions in `util/error.h` consistently return a `bilingual_str`. We've decided to use this as error message type so let's roll with it. This has no functional changes: no messages are changed, no new translation messages are defined.
2020-06-05 14:26:16 +02:00
bilingual_str error;
Make whitebind/whitelist permissions more flexible
2019-06-20 18:37:51 +09:00
NetWhitebindPermissions whitebindPermissions;
NetWhitelistPermissions whitelistPermissions;
// Detect invalid white bind
BOOST_CHECK(!NetWhitebindPermissions::TryParse("", whitebindPermissions, error));
refactor: Error message bilingual_str consistency - Move the decision whether to translate an error message to where it is defined. This simplifies call sites: no more `InitError(Untranslated(...))`. - Make all functions in `util/error.h` consistently return a `bilingual_str`. We've decided to use this as error message type so let's roll with it. This has no functional changes: no messages are changed, no new translation messages are defined.
2020-06-05 14:26:16 +02:00
BOOST_CHECK(error.original.find("Cannot resolve -whitebind address") != std::string::npos);
Make whitebind/whitelist permissions more flexible
2019-06-20 18:37:51 +09:00
BOOST_CHECK(!NetWhitebindPermissions::TryParse("127.0.0.1", whitebindPermissions, error));
refactor: Error message bilingual_str consistency - Move the decision whether to translate an error message to where it is defined. This simplifies call sites: no more `InitError(Untranslated(...))`. - Make all functions in `util/error.h` consistently return a `bilingual_str`. We've decided to use this as error message type so let's roll with it. This has no functional changes: no messages are changed, no new translation messages are defined.
2020-06-05 14:26:16 +02:00
BOOST_CHECK(error.original.find("Need to specify a port with -whitebind") != std::string::npos);
Make whitebind/whitelist permissions more flexible
2019-06-20 18:37:51 +09:00
BOOST_CHECK(!NetWhitebindPermissions::TryParse("", whitebindPermissions, error));
// If no permission flags, assume backward compatibility
BOOST_CHECK(NetWhitebindPermissions::TryParse("1.2.3.4:32", whitebindPermissions, error));
BOOST_CHECK(error.empty());
scripted-diff: add NetPermissionFlags scopes where not already present -BEGIN VERIFY SCRIPT- s() { git grep -l "$1" -- 'src' ':!src/net_permissions.h' | xargs sed -i -E "s/([^:])$1/\1NetPermissionFlags::$1/"; } s 'PF_NONE' s 'PF_BLOOMFILTER' s 'PF_RELAY' s 'PF_FORCERELAY' s 'PF_DOWNLOAD' s 'PF_NOBAN' s 'PF_MEMPOOL' s 'PF_ADDR' s 'PF_ISIMPLICIT' s 'PF_ALL' -END VERIFY SCRIPT- Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>
2021-03-22 19:19:05 +01:00
BOOST_CHECK_EQUAL(whitebindPermissions.m_flags, NetPermissionFlags::PF_ISIMPLICIT);
BOOST_CHECK(NetPermissions::HasFlag(whitebindPermissions.m_flags, NetPermissionFlags::PF_ISIMPLICIT));
NetPermissions::ClearFlag(whitebindPermissions.m_flags, NetPermissionFlags::PF_ISIMPLICIT);
BOOST_CHECK(!NetPermissions::HasFlag(whitebindPermissions.m_flags, NetPermissionFlags::PF_ISIMPLICIT));
BOOST_CHECK_EQUAL(whitebindPermissions.m_flags, NetPermissionFlags::PF_NONE);
NetPermissions::AddFlag(whitebindPermissions.m_flags, NetPermissionFlags::PF_ISIMPLICIT);
BOOST_CHECK(NetPermissions::HasFlag(whitebindPermissions.m_flags, NetPermissionFlags::PF_ISIMPLICIT));
Make whitebind/whitelist permissions more flexible
2019-06-20 18:37:51 +09:00
// Can set one permission
BOOST_CHECK(NetWhitebindPermissions::TryParse("bloom@1.2.3.4:32", whitebindPermissions, error));
scripted-diff: add NetPermissionFlags scopes where not already present -BEGIN VERIFY SCRIPT- s() { git grep -l "$1" -- 'src' ':!src/net_permissions.h' | xargs sed -i -E "s/([^:])$1/\1NetPermissionFlags::$1/"; } s 'PF_NONE' s 'PF_BLOOMFILTER' s 'PF_RELAY' s 'PF_FORCERELAY' s 'PF_DOWNLOAD' s 'PF_NOBAN' s 'PF_MEMPOOL' s 'PF_ADDR' s 'PF_ISIMPLICIT' s 'PF_ALL' -END VERIFY SCRIPT- Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>
2021-03-22 19:19:05 +01:00
BOOST_CHECK_EQUAL(whitebindPermissions.m_flags, NetPermissionFlags::PF_BLOOMFILTER);
Make whitebind/whitelist permissions more flexible
2019-06-20 18:37:51 +09:00
BOOST_CHECK(NetWhitebindPermissions::TryParse("@1.2.3.4:32", whitebindPermissions, error));
scripted-diff: add NetPermissionFlags scopes where not already present -BEGIN VERIFY SCRIPT- s() { git grep -l "$1" -- 'src' ':!src/net_permissions.h' | xargs sed -i -E "s/([^:])$1/\1NetPermissionFlags::$1/"; } s 'PF_NONE' s 'PF_BLOOMFILTER' s 'PF_RELAY' s 'PF_FORCERELAY' s 'PF_DOWNLOAD' s 'PF_NOBAN' s 'PF_MEMPOOL' s 'PF_ADDR' s 'PF_ISIMPLICIT' s 'PF_ALL' -END VERIFY SCRIPT- Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>
2021-03-22 19:19:05 +01:00
BOOST_CHECK_EQUAL(whitebindPermissions.m_flags, NetPermissionFlags::PF_NONE);
Make whitebind/whitelist permissions more flexible
2019-06-20 18:37:51 +09:00
test: add net permissions noban/download unit test coverage to clarify/test the relationship and NetPermissions operations involving the NetPermissionFlags PF_NOBAN and PF_DOWNLOAD. Co-authored-by: Vasil Dimov <vd@FreeBSD.org>
2021-04-09 20:32:40 +02:00
NetWhitebindPermissions noban, noban_download, download_noban, download;
// "noban" implies "download"
BOOST_REQUIRE(NetWhitebindPermissions::TryParse("noban@1.2.3.4:32", noban, error));
BOOST_CHECK_EQUAL(noban.m_flags, NetPermissionFlags::PF_NOBAN);
BOOST_CHECK(NetPermissions::HasFlag(noban.m_flags, NetPermissionFlags::PF_DOWNLOAD));
BOOST_CHECK(NetPermissions::HasFlag(noban.m_flags, NetPermissionFlags::PF_NOBAN));
// "noban,download" is equivalent to "noban"
BOOST_REQUIRE(NetWhitebindPermissions::TryParse("noban,download@1.2.3.4:32", noban_download, error));
BOOST_CHECK_EQUAL(noban_download.m_flags, noban.m_flags);
// "download,noban" is equivalent to "noban"
BOOST_REQUIRE(NetWhitebindPermissions::TryParse("download,noban@1.2.3.4:32", download_noban, error));
BOOST_CHECK_EQUAL(download_noban.m_flags, noban.m_flags);
// "download" excludes (does not imply) "noban"
BOOST_REQUIRE(NetWhitebindPermissions::TryParse("download@1.2.3.4:32", download, error));
BOOST_CHECK_EQUAL(download.m_flags, NetPermissionFlags::PF_DOWNLOAD);
BOOST_CHECK(NetPermissions::HasFlag(download.m_flags, NetPermissionFlags::PF_DOWNLOAD));
BOOST_CHECK(!NetPermissions::HasFlag(download.m_flags, NetPermissionFlags::PF_NOBAN));
Make whitebind/whitelist permissions more flexible
2019-06-20 18:37:51 +09:00
// Happy path, can parse flags
BOOST_CHECK(NetWhitebindPermissions::TryParse("bloom,forcerelay@1.2.3.4:32", whitebindPermissions, error));
// forcerelay should also activate the relay permission
scripted-diff: add NetPermissionFlags scopes where not already present -BEGIN VERIFY SCRIPT- s() { git grep -l "$1" -- 'src' ':!src/net_permissions.h' | xargs sed -i -E "s/([^:])$1/\1NetPermissionFlags::$1/"; } s 'PF_NONE' s 'PF_BLOOMFILTER' s 'PF_RELAY' s 'PF_FORCERELAY' s 'PF_DOWNLOAD' s 'PF_NOBAN' s 'PF_MEMPOOL' s 'PF_ADDR' s 'PF_ISIMPLICIT' s 'PF_ALL' -END VERIFY SCRIPT- Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>
2021-03-22 19:19:05 +01:00
BOOST_CHECK_EQUAL(whitebindPermissions.m_flags, NetPermissionFlags::PF_BLOOMFILTER | NetPermissionFlags::PF_FORCERELAY | NetPermissionFlags::PF_RELAY);
Make whitebind/whitelist permissions more flexible
2019-06-20 18:37:51 +09:00
BOOST_CHECK(NetWhitebindPermissions::TryParse("bloom,relay,noban@1.2.3.4:32", whitebindPermissions, error));
scripted-diff: add NetPermissionFlags scopes where not already present -BEGIN VERIFY SCRIPT- s() { git grep -l "$1" -- 'src' ':!src/net_permissions.h' | xargs sed -i -E "s/([^:])$1/\1NetPermissionFlags::$1/"; } s 'PF_NONE' s 'PF_BLOOMFILTER' s 'PF_RELAY' s 'PF_FORCERELAY' s 'PF_DOWNLOAD' s 'PF_NOBAN' s 'PF_MEMPOOL' s 'PF_ADDR' s 'PF_ISIMPLICIT' s 'PF_ALL' -END VERIFY SCRIPT- Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>
2021-03-22 19:19:05 +01:00
BOOST_CHECK_EQUAL(whitebindPermissions.m_flags, NetPermissionFlags::PF_BLOOMFILTER | NetPermissionFlags::PF_RELAY | NetPermissionFlags::PF_NOBAN);
Make whitebind/whitelist permissions more flexible
2019-06-20 18:37:51 +09:00
BOOST_CHECK(NetWhitebindPermissions::TryParse("bloom,forcerelay,noban@1.2.3.4:32", whitebindPermissions, error));
BOOST_CHECK(NetWhitebindPermissions::TryParse("all@1.2.3.4:32", whitebindPermissions, error));
scripted-diff: add NetPermissionFlags scopes where not already present -BEGIN VERIFY SCRIPT- s() { git grep -l "$1" -- 'src' ':!src/net_permissions.h' | xargs sed -i -E "s/([^:])$1/\1NetPermissionFlags::$1/"; } s 'PF_NONE' s 'PF_BLOOMFILTER' s 'PF_RELAY' s 'PF_FORCERELAY' s 'PF_DOWNLOAD' s 'PF_NOBAN' s 'PF_MEMPOOL' s 'PF_ADDR' s 'PF_ISIMPLICIT' s 'PF_ALL' -END VERIFY SCRIPT- Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>
2021-03-22 19:19:05 +01:00
BOOST_CHECK_EQUAL(whitebindPermissions.m_flags, NetPermissionFlags::PF_ALL);
Make whitebind/whitelist permissions more flexible
2019-06-20 18:37:51 +09:00
// Allow dups
BOOST_CHECK(NetWhitebindPermissions::TryParse("bloom,relay,noban,noban@1.2.3.4:32", whitebindPermissions, error));
scripted-diff: add NetPermissionFlags scopes where not already present -BEGIN VERIFY SCRIPT- s() { git grep -l "$1" -- 'src' ':!src/net_permissions.h' | xargs sed -i -E "s/([^:])$1/\1NetPermissionFlags::$1/"; } s 'PF_NONE' s 'PF_BLOOMFILTER' s 'PF_RELAY' s 'PF_FORCERELAY' s 'PF_DOWNLOAD' s 'PF_NOBAN' s 'PF_MEMPOOL' s 'PF_ADDR' s 'PF_ISIMPLICIT' s 'PF_ALL' -END VERIFY SCRIPT- Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>
2021-03-22 19:19:05 +01:00
BOOST_CHECK_EQUAL(whitebindPermissions.m_flags, NetPermissionFlags::PF_BLOOMFILTER | NetPermissionFlags::PF_RELAY | NetPermissionFlags::PF_NOBAN | NetPermissionFlags::PF_DOWNLOAD); // "noban" implies "download"
Make whitebind/whitelist permissions more flexible
2019-06-20 18:37:51 +09:00
// Allow empty
BOOST_CHECK(NetWhitebindPermissions::TryParse("bloom,relay,,noban@1.2.3.4:32", whitebindPermissions, error));
scripted-diff: add NetPermissionFlags scopes where not already present -BEGIN VERIFY SCRIPT- s() { git grep -l "$1" -- 'src' ':!src/net_permissions.h' | xargs sed -i -E "s/([^:])$1/\1NetPermissionFlags::$1/"; } s 'PF_NONE' s 'PF_BLOOMFILTER' s 'PF_RELAY' s 'PF_FORCERELAY' s 'PF_DOWNLOAD' s 'PF_NOBAN' s 'PF_MEMPOOL' s 'PF_ADDR' s 'PF_ISIMPLICIT' s 'PF_ALL' -END VERIFY SCRIPT- Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>
2021-03-22 19:19:05 +01:00
BOOST_CHECK_EQUAL(whitebindPermissions.m_flags, NetPermissionFlags::PF_BLOOMFILTER | NetPermissionFlags::PF_RELAY | NetPermissionFlags::PF_NOBAN);
Make whitebind/whitelist permissions more flexible
2019-06-20 18:37:51 +09:00
BOOST_CHECK(NetWhitebindPermissions::TryParse(",@1.2.3.4:32", whitebindPermissions, error));
scripted-diff: add NetPermissionFlags scopes where not already present -BEGIN VERIFY SCRIPT- s() { git grep -l "$1" -- 'src' ':!src/net_permissions.h' | xargs sed -i -E "s/([^:])$1/\1NetPermissionFlags::$1/"; } s 'PF_NONE' s 'PF_BLOOMFILTER' s 'PF_RELAY' s 'PF_FORCERELAY' s 'PF_DOWNLOAD' s 'PF_NOBAN' s 'PF_MEMPOOL' s 'PF_ADDR' s 'PF_ISIMPLICIT' s 'PF_ALL' -END VERIFY SCRIPT- Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>
2021-03-22 19:19:05 +01:00
BOOST_CHECK_EQUAL(whitebindPermissions.m_flags, NetPermissionFlags::PF_NONE);
Make whitebind/whitelist permissions more flexible
2019-06-20 18:37:51 +09:00
BOOST_CHECK(NetWhitebindPermissions::TryParse(",,@1.2.3.4:32", whitebindPermissions, error));
scripted-diff: add NetPermissionFlags scopes where not already present -BEGIN VERIFY SCRIPT- s() { git grep -l "$1" -- 'src' ':!src/net_permissions.h' | xargs sed -i -E "s/([^:])$1/\1NetPermissionFlags::$1/"; } s 'PF_NONE' s 'PF_BLOOMFILTER' s 'PF_RELAY' s 'PF_FORCERELAY' s 'PF_DOWNLOAD' s 'PF_NOBAN' s 'PF_MEMPOOL' s 'PF_ADDR' s 'PF_ISIMPLICIT' s 'PF_ALL' -END VERIFY SCRIPT- Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>
2021-03-22 19:19:05 +01:00
BOOST_CHECK_EQUAL(whitebindPermissions.m_flags, NetPermissionFlags::PF_NONE);
Make whitebind/whitelist permissions more flexible
2019-06-20 18:37:51 +09:00
// Detect invalid flag
BOOST_CHECK(!NetWhitebindPermissions::TryParse("bloom,forcerelay,oopsie@1.2.3.4:32", whitebindPermissions, error));
refactor: Error message bilingual_str consistency - Move the decision whether to translate an error message to where it is defined. This simplifies call sites: no more `InitError(Untranslated(...))`. - Make all functions in `util/error.h` consistently return a `bilingual_str`. We've decided to use this as error message type so let's roll with it. This has no functional changes: no messages are changed, no new translation messages are defined.
2020-06-05 14:26:16 +02:00
BOOST_CHECK(error.original.find("Invalid P2P permission") != std::string::npos);
Make whitebind/whitelist permissions more flexible
2019-06-20 18:37:51 +09:00
doc: Use precise permission flags where possible
2020-07-09 17:59:54 +02:00
// Check netmask error
Make whitebind/whitelist permissions more flexible
2019-06-20 18:37:51 +09:00
BOOST_CHECK(!NetWhitelistPermissions::TryParse("bloom,forcerelay,noban@1.2.3.4:32", whitelistPermissions, error));
refactor: Error message bilingual_str consistency - Move the decision whether to translate an error message to where it is defined. This simplifies call sites: no more `InitError(Untranslated(...))`. - Make all functions in `util/error.h` consistently return a `bilingual_str`. We've decided to use this as error message type so let's roll with it. This has no functional changes: no messages are changed, no new translation messages are defined.
2020-06-05 14:26:16 +02:00
BOOST_CHECK(error.original.find("Invalid netmask specified in -whitelist") != std::string::npos);
Make whitebind/whitelist permissions more flexible
2019-06-20 18:37:51 +09:00
// Happy path for whitelist parsing
BOOST_CHECK(NetWhitelistPermissions::TryParse("noban@1.2.3.4", whitelistPermissions, error));
scripted-diff: add NetPermissionFlags scopes where not already present -BEGIN VERIFY SCRIPT- s() { git grep -l "$1" -- 'src' ':!src/net_permissions.h' | xargs sed -i -E "s/([^:])$1/\1NetPermissionFlags::$1/"; } s 'PF_NONE' s 'PF_BLOOMFILTER' s 'PF_RELAY' s 'PF_FORCERELAY' s 'PF_DOWNLOAD' s 'PF_NOBAN' s 'PF_MEMPOOL' s 'PF_ADDR' s 'PF_ISIMPLICIT' s 'PF_ALL' -END VERIFY SCRIPT- Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>
2021-03-22 19:19:05 +01:00
BOOST_CHECK_EQUAL(whitelistPermissions.m_flags, NetPermissionFlags::PF_NOBAN);
test: add net permissions noban/download unit test coverage to clarify/test the relationship and NetPermissions operations involving the NetPermissionFlags PF_NOBAN and PF_DOWNLOAD. Co-authored-by: Vasil Dimov <vd@FreeBSD.org>
2021-04-09 20:32:40 +02:00
BOOST_CHECK(NetPermissions::HasFlag(whitelistPermissions.m_flags, NetPermissionFlags::PF_NOBAN));
Make whitebind/whitelist permissions more flexible
2019-06-20 18:37:51 +09:00
BOOST_CHECK(NetWhitelistPermissions::TryParse("bloom,forcerelay,noban,relay@1.2.3.4/32", whitelistPermissions, error));
scripted-diff: add NetPermissionFlags scopes where not already present -BEGIN VERIFY SCRIPT- s() { git grep -l "$1" -- 'src' ':!src/net_permissions.h' | xargs sed -i -E "s/([^:])$1/\1NetPermissionFlags::$1/"; } s 'PF_NONE' s 'PF_BLOOMFILTER' s 'PF_RELAY' s 'PF_FORCERELAY' s 'PF_DOWNLOAD' s 'PF_NOBAN' s 'PF_MEMPOOL' s 'PF_ADDR' s 'PF_ISIMPLICIT' s 'PF_ALL' -END VERIFY SCRIPT- Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>
2021-03-22 19:19:05 +01:00
BOOST_CHECK_EQUAL(whitelistPermissions.m_flags, NetPermissionFlags::PF_BLOOMFILTER | NetPermissionFlags::PF_FORCERELAY | NetPermissionFlags::PF_NOBAN | NetPermissionFlags::PF_RELAY);
Make whitebind/whitelist permissions more flexible
2019-06-20 18:37:51 +09:00
BOOST_CHECK(error.empty());
BOOST_CHECK_EQUAL(whitelistPermissions.m_subnet.ToString(), "1.2.3.4/32");
BOOST_CHECK(NetWhitelistPermissions::TryParse("bloom,forcerelay,noban,relay,mempool@1.2.3.4/32", whitelistPermissions, error));
scripted-diff: add NetPermissionFlags scopes where not already present -BEGIN VERIFY SCRIPT- s() { git grep -l "$1" -- 'src' ':!src/net_permissions.h' | xargs sed -i -E "s/([^:])$1/\1NetPermissionFlags::$1/"; } s 'PF_NONE' s 'PF_BLOOMFILTER' s 'PF_RELAY' s 'PF_FORCERELAY' s 'PF_DOWNLOAD' s 'PF_NOBAN' s 'PF_MEMPOOL' s 'PF_ADDR' s 'PF_ISIMPLICIT' s 'PF_ALL' -END VERIFY SCRIPT- Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>
2021-03-22 19:19:05 +01:00
const auto strings = NetPermissions::ToStrings(NetPermissionFlags::PF_ALL);
Add addr permission flag enabling non-cached addr sharing
2020-06-03 18:51:34 +03:00
BOOST_CHECK_EQUAL(strings.size(), 7U);
Make whitebind/whitelist permissions more flexible
2019-06-20 18:37:51 +09:00
BOOST_CHECK(std::find(strings.begin(), strings.end(), "bloomfilter") != strings.end());
BOOST_CHECK(std::find(strings.begin(), strings.end(), "forcerelay") != strings.end());
BOOST_CHECK(std::find(strings.begin(), strings.end(), "relay") != strings.end());
BOOST_CHECK(std::find(strings.begin(), strings.end(), "noban") != strings.end());
BOOST_CHECK(std::find(strings.begin(), strings.end(), "mempool") != strings.end());
net: Extract download permission from noban
2020-06-06 17:07:25 +02:00
BOOST_CHECK(std::find(strings.begin(), strings.end(), "download") != strings.end());
Add addr permission flag enabling non-cached addr sharing
2020-06-03 18:51:34 +03:00
BOOST_CHECK(std::find(strings.begin(), strings.end(), "addr") != strings.end());
Make whitebind/whitelist permissions more flexible
2019-06-20 18:37:51 +09:00
}
tests: Add tests to make sure lookup methods fail on std::string parameters with embedded NUL characters
2019-12-16 11:46:19 +00:00
BOOST_AUTO_TEST_CASE(netbase_dont_resolve_strings_with_embedded_nul_characters)
{
CNetAddr addr;
test: fix creation of std::string objects with \0s A string literal `"abc"` contains a terminating `\0`, so that is 4 bytes. There is no need to write `"abc\0"` unless two terminating `\0`s are necessary. `std::string` objects do not internally contain a terminating `\0`, so `std::string("abc")` creates a string with size 3 and is the same as `std::string("abc", 3)`. In `"\01"` the `01` part is interpreted as one number (1) and that is the same as `"\1"` which is a string like `{1, 0}` whereas `"\0z"` is a string like `{0, 'z', 0}`. To create a string like `{0, '1', 0}` one must use `"\0" "1"`. Adjust the tests accordingly.
2020-09-23 08:40:38 +02:00
BOOST_CHECK(LookupHost("127.0.0.1"s, addr, false));
BOOST_CHECK(!LookupHost("127.0.0.1\0"s, addr, false));
BOOST_CHECK(!LookupHost("127.0.0.1\0example.com"s, addr, false));
BOOST_CHECK(!LookupHost("127.0.0.1\0example.com\0"s, addr, false));
tests: Add tests to make sure lookup methods fail on std::string parameters with embedded NUL characters
2019-12-16 11:46:19 +00:00
CSubNet ret;
test: fix creation of std::string objects with \0s A string literal `"abc"` contains a terminating `\0`, so that is 4 bytes. There is no need to write `"abc\0"` unless two terminating `\0`s are necessary. `std::string` objects do not internally contain a terminating `\0`, so `std::string("abc")` creates a string with size 3 and is the same as `std::string("abc", 3)`. In `"\01"` the `01` part is interpreted as one number (1) and that is the same as `"\1"` which is a string like `{1, 0}` whereas `"\0z"` is a string like `{0, 'z', 0}`. To create a string like `{0, '1', 0}` one must use `"\0" "1"`. Adjust the tests accordingly.
2020-09-23 08:40:38 +02:00
BOOST_CHECK(LookupSubNet("1.2.3.0/24"s, ret));
BOOST_CHECK(!LookupSubNet("1.2.3.0/24\0"s, ret));
BOOST_CHECK(!LookupSubNet("1.2.3.0/24\0example.com"s, ret));
BOOST_CHECK(!LookupSubNet("1.2.3.0/24\0example.com\0"s, ret));
net: allow CSubNet of non-IP networks Allow creation of valid `CSubNet` objects of non-IP networks and only match the single address they were created from (like /32 for IPv4 or /128 for IPv6). This fixes a deficiency in `CConnman::DisconnectNode(const CNetAddr& addr)` and in `BanMan` which assume that creating a subnet from any address using the `CSubNet(CNetAddr)` constructor would later match that address only. Before this change a non-IP subnet would be invalid and would not match any address.
2021-01-04 18:37:52 +01:00
BOOST_CHECK(LookupSubNet("5wyqrzbvrdsumnok.onion"s, ret));
test: fix creation of std::string objects with \0s A string literal `"abc"` contains a terminating `\0`, so that is 4 bytes. There is no need to write `"abc\0"` unless two terminating `\0`s are necessary. `std::string` objects do not internally contain a terminating `\0`, so `std::string("abc")` creates a string with size 3 and is the same as `std::string("abc", 3)`. In `"\01"` the `01` part is interpreted as one number (1) and that is the same as `"\1"` which is a string like `{1, 0}` whereas `"\0z"` is a string like `{0, 'z', 0}`. To create a string like `{0, '1', 0}` one must use `"\0" "1"`. Adjust the tests accordingly.
2020-09-23 08:40:38 +02:00
BOOST_CHECK(!LookupSubNet("5wyqrzbvrdsumnok.onion\0"s, ret));
BOOST_CHECK(!LookupSubNet("5wyqrzbvrdsumnok.onion\0example.com"s, ret));
BOOST_CHECK(!LookupSubNet("5wyqrzbvrdsumnok.onion\0example.com\0"s, ret));
tests: Add tests to make sure lookup methods fail on std::string parameters with embedded NUL characters
2019-12-16 11:46:19 +00:00
}
net: CAddress & CAddrMan: (un)serialize as ADDRv2 Change the serialization of `CAddrMan` to serialize its addresses in ADDRv2/BIP155 format by default. Introduce a new `CAddrMan` format version (3). Add support for ADDRv2 format in `CAddress` (un)serialization. Co-authored-by: Carl Dong <contact@carldong.me>
2020-05-19 17:39:05 +02:00
// Since CNetAddr (un)ser is tested separately in net_tests.cpp here we only
// try a few edge cases for port, service flags and time.
static const std::vector<CAddress> fixture_addresses({
CAddress(
tests: don't export in6addr_loopback Don't export `in6addr_loopback` because that upsets `contrib/devtools/symbol-check.py` Fixes https://github.com/bitcoin/bitcoin/issues/20127
2020-10-12 10:25:08 +02:00
CService(CNetAddr(in6_addr(IN6ADDR_LOOPBACK_INIT)), 0 /* port */),
net: CAddress & CAddrMan: (un)serialize as ADDRv2 Change the serialization of `CAddrMan` to serialize its addresses in ADDRv2/BIP155 format by default. Introduce a new `CAddrMan` format version (3). Add support for ADDRv2 format in `CAddress` (un)serialization. Co-authored-by: Carl Dong <contact@carldong.me>
2020-05-19 17:39:05 +02:00
NODE_NONE,
0x4966bc61U /* Fri Jan 9 02:54:25 UTC 2009 */
),
CAddress(
tests: don't export in6addr_loopback Don't export `in6addr_loopback` because that upsets `contrib/devtools/symbol-check.py` Fixes https://github.com/bitcoin/bitcoin/issues/20127
2020-10-12 10:25:08 +02:00
CService(CNetAddr(in6_addr(IN6ADDR_LOOPBACK_INIT)), 0x00f1 /* port */),
net: CAddress & CAddrMan: (un)serialize as ADDRv2 Change the serialization of `CAddrMan` to serialize its addresses in ADDRv2/BIP155 format by default. Introduce a new `CAddrMan` format version (3). Add support for ADDRv2 format in `CAddress` (un)serialization. Co-authored-by: Carl Dong <contact@carldong.me>
2020-05-19 17:39:05 +02:00
NODE_NETWORK,
0x83766279U /* Tue Nov 22 11:22:33 UTC 2039 */
),
CAddress(
tests: don't export in6addr_loopback Don't export `in6addr_loopback` because that upsets `contrib/devtools/symbol-check.py` Fixes https://github.com/bitcoin/bitcoin/issues/20127
2020-10-12 10:25:08 +02:00
CService(CNetAddr(in6_addr(IN6ADDR_LOOPBACK_INIT)), 0xf1f2 /* port */),
net: CAddress & CAddrMan: (un)serialize as ADDRv2 Change the serialization of `CAddrMan` to serialize its addresses in ADDRv2/BIP155 format by default. Introduce a new `CAddrMan` format version (3). Add support for ADDRv2 format in `CAddress` (un)serialization. Co-authored-by: Carl Dong <contact@carldong.me>
2020-05-19 17:39:05 +02:00
static_cast<ServiceFlags>(NODE_WITNESS | NODE_COMPACT_FILTERS | NODE_NETWORK_LIMITED),
0xffffffffU /* Sun Feb 7 06:28:15 UTC 2106 */
)
});
// fixture_addresses should equal to this when serialized in V1 format.
// When this is unserialized from V1 format it should equal to fixture_addresses.
static constexpr const char* stream_addrv1_hex =
"03" // number of entries
"61bc6649" // time, Fri Jan 9 02:54:25 UTC 2009
"0000000000000000" // service flags, NODE_NONE
"00000000000000000000000000000001" // address, fixed 16 bytes (IPv4 embedded in IPv6)
"0000" // port
"79627683" // time, Tue Nov 22 11:22:33 UTC 2039
"0100000000000000" // service flags, NODE_NETWORK
"00000000000000000000000000000001" // address, fixed 16 bytes (IPv6)
"00f1" // port
"ffffffff" // time, Sun Feb 7 06:28:15 UTC 2106
"4804000000000000" // service flags, NODE_WITNESS | NODE_COMPACT_FILTERS | NODE_NETWORK_LIMITED
"00000000000000000000000000000001" // address, fixed 16 bytes (IPv6)
"f1f2"; // port
// fixture_addresses should equal to this when serialized in V2 format.
// When this is unserialized from V2 format it should equal to fixture_addresses.
static constexpr const char* stream_addrv2_hex =
"03" // number of entries
"61bc6649" // time, Fri Jan 9 02:54:25 UTC 2009
"00" // service flags, COMPACTSIZE(NODE_NONE)
"02" // network id, IPv6
"10" // address length, COMPACTSIZE(16)
"00000000000000000000000000000001" // address
"0000" // port
"79627683" // time, Tue Nov 22 11:22:33 UTC 2039
"01" // service flags, COMPACTSIZE(NODE_NETWORK)
"02" // network id, IPv6
"10" // address length, COMPACTSIZE(16)
"00000000000000000000000000000001" // address
"00f1" // port
"ffffffff" // time, Sun Feb 7 06:28:15 UTC 2106
"fd4804" // service flags, COMPACTSIZE(NODE_WITNESS | NODE_COMPACT_FILTERS | NODE_NETWORK_LIMITED)
"02" // network id, IPv6
"10" // address length, COMPACTSIZE(16)
"00000000000000000000000000000001" // address
"f1f2"; // port
BOOST_AUTO_TEST_CASE(caddress_serialize_v1)
{
CDataStream s(SER_NETWORK, PROTOCOL_VERSION);
s << fixture_addresses;
BOOST_CHECK_EQUAL(HexStr(s), stream_addrv1_hex);
}
BOOST_AUTO_TEST_CASE(caddress_unserialize_v1)
{
CDataStream s(ParseHex(stream_addrv1_hex), SER_NETWORK, PROTOCOL_VERSION);
std::vector<CAddress> addresses_unserialized;
s >> addresses_unserialized;
BOOST_CHECK(fixture_addresses == addresses_unserialized);
}
BOOST_AUTO_TEST_CASE(caddress_serialize_v2)
{
CDataStream s(SER_NETWORK, PROTOCOL_VERSION | ADDRV2_FORMAT);
s << fixture_addresses;
BOOST_CHECK_EQUAL(HexStr(s), stream_addrv2_hex);
}
BOOST_AUTO_TEST_CASE(caddress_unserialize_v2)
{
CDataStream s(ParseHex(stream_addrv2_hex), SER_NETWORK, PROTOCOL_VERSION | ADDRV2_FORMAT);
std::vector<CAddress> addresses_unserialized;
s >> addresses_unserialized;
BOOST_CHECK(fixture_addresses == addresses_unserialized);
}
Add netbase tests
2012-06-08 18:42:05 +02:00
BOOST_AUTO_TEST_SUITE_END()
Reference in a new issue Copy permalink