2020-12-31 09:48:25 +01:00
|
|
|
// Copyright (c) 2016-2020 The Bitcoin Core developers
|
2015-12-16 14:57:54 -05:00
|
|
|
// Distributed under the MIT software license, see the accompanying
|
|
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
|
2017-11-10 13:57:53 +13:00
|
|
|
#include <policy/rbf.h>
|
2021-07-27 14:23:40 +01:00
|
|
|
|
|
|
|
#include <policy/settings.h>
|
|
|
|
#include <tinyformat.h>
|
|
|
|
#include <util/moneystr.h>
|
2019-04-02 17:03:37 -04:00
|
|
|
#include <util/rbf.h>
|
2015-12-16 14:57:54 -05:00
|
|
|
|
2019-02-23 11:04:20 -05:00
|
|
|
RBFTransactionState IsRBFOptIn(const CTransaction& tx, const CTxMemPool& pool)
|
2015-12-16 14:57:54 -05:00
|
|
|
{
|
|
|
|
AssertLockHeld(pool.cs);
|
|
|
|
|
2021-08-16 10:19:15 +01:00
|
|
|
CTxMemPool::setEntries ancestors;
|
2015-12-16 14:57:54 -05:00
|
|
|
|
|
|
|
// First check the transaction itself.
|
2016-04-05 14:20:49 +02:00
|
|
|
if (SignalsOptInRBF(tx)) {
|
2018-03-09 15:03:40 +01:00
|
|
|
return RBFTransactionState::REPLACEABLE_BIP125;
|
2015-12-16 14:57:54 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
// If this transaction is not in our mempool, then we can't be sure
|
|
|
|
// we will know about all its inputs.
|
2016-04-05 14:20:49 +02:00
|
|
|
if (!pool.exists(tx.GetHash())) {
|
2018-03-09 15:03:40 +01:00
|
|
|
return RBFTransactionState::UNKNOWN;
|
2015-12-16 14:57:54 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
// If all the inputs have nSequence >= maxint-1, it still might be
|
|
|
|
// signaled for RBF if any unconfirmed parents have signaled.
|
|
|
|
uint64_t noLimit = std::numeric_limits<uint64_t>::max();
|
|
|
|
std::string dummy;
|
2016-04-05 14:20:49 +02:00
|
|
|
CTxMemPoolEntry entry = *pool.mapTx.find(tx.GetHash());
|
2021-08-16 10:19:15 +01:00
|
|
|
pool.CalculateMemPoolAncestors(entry, ancestors, noLimit, noLimit, noLimit, noLimit, dummy, false);
|
2015-12-16 14:57:54 -05:00
|
|
|
|
2021-08-16 10:19:15 +01:00
|
|
|
for (CTxMemPool::txiter it : ancestors) {
|
2015-12-16 14:57:54 -05:00
|
|
|
if (SignalsOptInRBF(it->GetTx())) {
|
2018-03-09 15:03:40 +01:00
|
|
|
return RBFTransactionState::REPLACEABLE_BIP125;
|
2015-12-16 14:57:54 -05:00
|
|
|
}
|
|
|
|
}
|
2018-03-09 15:03:40 +01:00
|
|
|
return RBFTransactionState::FINAL;
|
2015-12-16 14:57:54 -05:00
|
|
|
}
|
2020-07-19 11:09:59 +02:00
|
|
|
|
|
|
|
RBFTransactionState IsRBFOptInEmptyMempool(const CTransaction& tx)
|
|
|
|
{
|
|
|
|
// If we don't have a local mempool we can only check the transaction itself.
|
|
|
|
return SignalsOptInRBF(tx) ? RBFTransactionState::REPLACEABLE_BIP125 : RBFTransactionState::UNKNOWN;
|
|
|
|
}
|
2021-07-27 14:23:40 +01:00
|
|
|
|
2021-09-02 15:27:37 +01:00
|
|
|
std::optional<std::string> GetEntriesForConflicts(const CTransaction& tx,
|
2021-08-16 10:19:15 +01:00
|
|
|
CTxMemPool& pool,
|
|
|
|
const CTxMemPool::setEntries& iters_conflicting,
|
|
|
|
CTxMemPool::setEntries& all_conflicts)
|
2021-07-27 14:23:40 +01:00
|
|
|
{
|
2021-08-16 10:19:15 +01:00
|
|
|
AssertLockHeld(pool.cs);
|
|
|
|
const uint256 txid = tx.GetHash();
|
2021-07-27 14:23:40 +01:00
|
|
|
uint64_t nConflictingCount = 0;
|
2021-08-16 10:19:15 +01:00
|
|
|
for (const auto& mi : iters_conflicting) {
|
2021-07-27 14:23:40 +01:00
|
|
|
nConflictingCount += mi->GetCountWithDescendants();
|
2021-09-01 09:54:04 +01:00
|
|
|
// This potentially overestimates the number of actual descendants but we just want to be
|
|
|
|
// conservative to avoid doing too much work.
|
2021-07-27 14:23:40 +01:00
|
|
|
if (nConflictingCount > MAX_BIP125_REPLACEMENT_CANDIDATES) {
|
2021-09-02 15:27:37 +01:00
|
|
|
return strprintf("rejecting replacement %s; too many potential replacements (%d > %d)\n",
|
2021-09-01 09:54:04 +01:00
|
|
|
txid.ToString(),
|
|
|
|
nConflictingCount,
|
|
|
|
MAX_BIP125_REPLACEMENT_CANDIDATES);
|
2021-07-27 14:23:40 +01:00
|
|
|
}
|
|
|
|
}
|
|
|
|
// If not too many to replace, then calculate the set of
|
|
|
|
// transactions that would have to be evicted
|
2021-08-16 10:19:15 +01:00
|
|
|
for (CTxMemPool::txiter it : iters_conflicting) {
|
|
|
|
pool.CalculateDescendants(it, all_conflicts);
|
2021-07-27 14:23:40 +01:00
|
|
|
}
|
2021-09-02 15:27:37 +01:00
|
|
|
return std::nullopt;
|
2021-07-27 14:23:40 +01:00
|
|
|
}
|
|
|
|
|
2021-08-03 13:13:43 +01:00
|
|
|
std::optional<std::string> HasNoNewUnconfirmed(const CTransaction& tx,
|
2021-08-16 10:19:15 +01:00
|
|
|
const CTxMemPool& pool,
|
|
|
|
const CTxMemPool::setEntries& iters_conflicting)
|
2021-08-03 13:13:43 +01:00
|
|
|
{
|
2021-08-16 10:19:15 +01:00
|
|
|
AssertLockHeld(pool.cs);
|
|
|
|
std::set<uint256> parents_of_conflicts;
|
|
|
|
for (const auto& mi : iters_conflicting) {
|
2021-09-01 09:54:04 +01:00
|
|
|
for (const CTxIn &txin : mi->GetTx().vin) {
|
2021-08-16 10:19:15 +01:00
|
|
|
parents_of_conflicts.insert(txin.prevout.hash);
|
2021-08-03 13:13:43 +01:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2021-09-01 09:54:04 +01:00
|
|
|
for (unsigned int j = 0; j < tx.vin.size(); j++) {
|
|
|
|
// We don't want to accept replacements that require low feerate junk to be mined first.
|
|
|
|
// Ideally we'd keep track of the ancestor feerates and make the decision based on that, but
|
|
|
|
// for now requiring all new inputs to be confirmed works.
|
2021-08-03 13:13:43 +01:00
|
|
|
//
|
2021-09-01 09:54:04 +01:00
|
|
|
// Note that if you relax this to make RBF a little more useful, this may break the
|
|
|
|
// CalculateMempoolAncestors RBF relaxation, above. See the comment above the first
|
|
|
|
// CalculateMempoolAncestors call for more info.
|
|
|
|
if (!parents_of_conflicts.count(tx.vin[j].prevout.hash)) {
|
|
|
|
// Rather than check the UTXO set - potentially expensive - it's cheaper to just check
|
|
|
|
// if the new input refers to a tx that's in the mempool.
|
2021-08-16 10:19:15 +01:00
|
|
|
if (pool.exists(tx.vin[j].prevout.hash)) {
|
2021-08-03 13:13:43 +01:00
|
|
|
return strprintf("replacement %s adds unconfirmed input, idx %d",
|
|
|
|
tx.GetHash().ToString(), j);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return std::nullopt;
|
|
|
|
}
|
2021-07-27 15:55:25 +01:00
|
|
|
|
2021-08-16 10:19:15 +01:00
|
|
|
std::optional<std::string> EntriesAndTxidsDisjoint(const CTxMemPool::setEntries& ancestors,
|
|
|
|
const std::set<uint256>& direct_conflicts,
|
2021-07-27 15:55:25 +01:00
|
|
|
const uint256& txid)
|
|
|
|
{
|
2021-09-01 09:54:04 +01:00
|
|
|
for (CTxMemPool::txiter ancestorIt : ancestors) {
|
2021-07-27 15:55:25 +01:00
|
|
|
const uint256 &hashAncestor = ancestorIt->GetTx().GetHash();
|
2021-09-01 09:54:04 +01:00
|
|
|
if (direct_conflicts.count(hashAncestor)) {
|
2021-07-27 15:55:25 +01:00
|
|
|
return strprintf("%s spends conflicting transaction %s",
|
|
|
|
txid.ToString(),
|
|
|
|
hashAncestor.ToString());
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return std::nullopt;
|
|
|
|
}
|
2021-08-11 15:51:27 +01:00
|
|
|
|
2021-08-16 10:19:15 +01:00
|
|
|
std::optional<std::string> PaysMoreThanConflicts(const CTxMemPool::setEntries& iters_conflicting,
|
|
|
|
CFeeRate replacement_feerate,
|
|
|
|
const uint256& txid)
|
2021-08-11 15:51:27 +01:00
|
|
|
{
|
2021-08-16 10:19:15 +01:00
|
|
|
for (const auto& mi : iters_conflicting) {
|
2021-09-01 09:54:04 +01:00
|
|
|
// Don't allow the replacement to reduce the feerate of the mempool.
|
2021-08-11 15:51:27 +01:00
|
|
|
//
|
2021-09-01 09:54:04 +01:00
|
|
|
// We usually don't want to accept replacements with lower feerates than what they replaced
|
|
|
|
// as that would lower the feerate of the next block. Requiring that the feerate always be
|
|
|
|
// increased is also an easy-to-reason about way to prevent DoS attacks via replacements.
|
2021-08-11 15:51:27 +01:00
|
|
|
//
|
2021-09-01 09:54:04 +01:00
|
|
|
// We only consider the feerates of transactions being directly replaced, not their indirect
|
|
|
|
// descendants. While that does mean high feerate children are ignored when deciding whether
|
|
|
|
// or not to replace, we do require the replacement to pay more overall fees too, mitigating
|
|
|
|
// most cases.
|
2021-08-16 10:19:15 +01:00
|
|
|
CFeeRate original_feerate(mi->GetModifiedFee(), mi->GetTxSize());
|
2021-09-01 09:54:04 +01:00
|
|
|
if (replacement_feerate <= original_feerate) {
|
2021-08-11 15:51:27 +01:00
|
|
|
return strprintf("rejecting replacement %s; new feerate %s <= old feerate %s",
|
2021-08-16 10:19:15 +01:00
|
|
|
txid.ToString(),
|
|
|
|
replacement_feerate.ToString(),
|
|
|
|
original_feerate.ToString());
|
2021-08-11 15:51:27 +01:00
|
|
|
}
|
|
|
|
}
|
|
|
|
return std::nullopt;
|
|
|
|
}
|
|
|
|
|
2021-08-16 10:19:15 +01:00
|
|
|
std::optional<std::string> PaysForRBF(CAmount original_fees,
|
|
|
|
CAmount replacement_fees,
|
|
|
|
size_t replacement_vsize,
|
|
|
|
const uint256& txid)
|
2021-08-11 15:51:41 +01:00
|
|
|
{
|
|
|
|
// The replacement must pay greater fees than the transactions it
|
|
|
|
// replaces - if we did the bandwidth used by those conflicting
|
|
|
|
// transactions would not be paid for.
|
2021-09-01 09:54:04 +01:00
|
|
|
if (replacement_fees < original_fees) {
|
2021-08-11 15:51:41 +01:00
|
|
|
return strprintf("rejecting replacement %s, less fees than conflicting txs; %s < %s",
|
2021-08-16 10:19:15 +01:00
|
|
|
txid.ToString(), FormatMoney(replacement_fees), FormatMoney(original_fees));
|
2021-08-11 15:51:41 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
// Finally in addition to paying more fees than the conflicts the
|
|
|
|
// new transaction must pay for its own bandwidth.
|
2021-08-16 10:19:15 +01:00
|
|
|
CAmount additional_fees = replacement_fees - original_fees;
|
2021-09-01 09:54:04 +01:00
|
|
|
if (additional_fees < ::incrementalRelayFee.GetFee(replacement_vsize)) {
|
2021-08-11 15:51:41 +01:00
|
|
|
return strprintf("rejecting replacement %s, not enough additional fees to relay; %s < %s",
|
2021-08-16 10:19:15 +01:00
|
|
|
txid.ToString(),
|
|
|
|
FormatMoney(additional_fees),
|
|
|
|
FormatMoney(::incrementalRelayFee.GetFee(replacement_vsize)));
|
2021-08-11 15:51:41 +01:00
|
|
|
}
|
|
|
|
return std::nullopt;
|
|
|
|
}
|