cemu-project_Mirror/Cemu-2024-03-05
1
0
Fork 0
Code Issues 224 Pull requests 11 Projects Releases Packages Wiki Activity

Minor localization adjustments #984

Merged
Fs00 merged 5 commits from strings-adjustments into main 2023-09-30 10:27:57 -03:00
Conversation 0 Commits 5 Files changed 10 +50 -56
Fs00 commented 2023-09-30 09:57:51 -03:00 (Migrated from github.com)
Copy link

This PR fixes some more untranslated UI strings I've stumbled upon.
While I was at it, I took the opportunity to make some minor improvements to the GUI code:

  • removed all usages of the wxT macro, which is useless since wxWidgets 3.0
  • addressed a small issue in commit f6c3c96d, which mistakenly added two translatable strings containing nothing or just newlines

One last thing: I added the wxString::FromUTF8 to the wxString <-> std::string conversions mentioned in the code style guidelines.
I think that it should be the preferred way to convert a std::string into a wxString. Also, wxWidgets 3.3 will add a FromUTF8 overload that takes a std::string_view, so we'll be able to use that one in place of our custom helper.

This PR fixes some more untranslated UI strings I've stumbled upon. While I was at it, I took the opportunity to make some minor improvements to the GUI code: - removed all usages of the [wxT](https://docs.wxwidgets.org/3.2/group__group__funcmacro__string.html#ga437ea6ba615b75dac8603e96ec864160) macro, which is [useless since wxWidgets 3.0](https://docs.wxwidgets.org/3.2/overview_changes_since28.html#overview_changes_unicode) - addressed a small issue in commit f6c3c96d, which mistakenly added two translatable strings containing nothing or just newlines One last thing: I added the `wxString::FromUTF8` to the `wxString <-> std::string` conversions mentioned in the code style guidelines. I think that it should be the preferred way to convert a `std::string` into a `wxString`. Also, wxWidgets 3.3 will add a [FromUTF8 overload that takes a std::string_view](https://docs.wxwidgets.org/latest/classwx_string.html#adf4cc48dd71ddff7f8d49684e38172a1), so we'll be able to use that one in place of our custom helper.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: cemu-project_Mirror/Cemu-2024-03-05#984
No description provided.
Delete branch "strings-adjustments"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?