cemu-project_Mirror/Cemu-2024-03-05
1
0
Fork 0
Code Issues 224 Pull requests 11 Projects Releases Packages Wiki Activity

Logging migration (socketLog_printf) #766

Merged
why-keith merged 5 commits from logging-migration-socketLog_printf into main 2023-04-15 18:08:22 -04:00
Conversation 2 Commits 5 Files changed 1 +47 -47
why-keith commented 2023-04-14 05:17:51 -04:00 (Migrated from github.com)
Copy link

Converts all instances of the socketLog_printf() logging method with the newer cemuLog_log().

Part of #703

Converts all instances of the socketLog_printf() logging method with the newer cemuLog_log(). Part of #703
Crementif (Migrated from github.com) requested changes 2023-04-14 05:43:38 -04:00
Crementif (Migrated from github.com) left a comment
Copy link

Looks good other then some LR and thread context logging that could be removed.

Looks good other then some LR and thread context logging that could be removed.
src/Cafe/OS/libs/nsysnet/nsysnet.cpp
Crementif (Migrated from github.com) commented 2023-04-14 05:38:34 -04:00
Copy link

The new logging system has a toggleable option to print out the LR for any log line so if we're really cleaning up all this logging it's better to just get rid of this since it's redundant while we're at it. Not sure if it was an issue in previous PRs, but it was apparent here.

	cemuLog_log(LogType::Socket, "recv({},0x{:08x},{},0x{:x})", hCPU->gpr[3], hCPU->gpr[4], hCPU->gpr[5], hCPU->gpr[6]);
The new logging system has a toggleable option to print out the LR for any log line so if we're really cleaning up all this logging it's better to just get rid of this since it's redundant while we're at it. Not sure if it was an issue in previous PRs, but it was apparent here. ```suggestion cemuLog_log(LogType::Socket, "recv({},0x{:08x},{},0x{:x})", hCPU->gpr[3], hCPU->gpr[4], hCPU->gpr[5], hCPU->gpr[6]); ```
src/Cafe/OS/libs/nsysnet/nsysnet.cpp
Crementif (Migrated from github.com) commented 2023-04-14 05:38:58 -04:00
Copy link
	cemuLog_log(LogType::Socket, "select({},0x{:08x},0x{:08x},0x{:08x},0x{:08x})", hCPU->gpr[3], hCPU->gpr[4], hCPU->gpr[5], hCPU->gpr[6], hCPU->gpr[7]);
```suggestion cemuLog_log(LogType::Socket, "select({},0x{:08x},0x{:08x},0x{:08x},0x{:08x})", hCPU->gpr[3], hCPU->gpr[4], hCPU->gpr[5], hCPU->gpr[6], hCPU->gpr[7]); ```
src/Cafe/OS/libs/nsysnet/nsysnet.cpp
Crementif (Migrated from github.com) commented 2023-04-14 05:39:23 -04:00
Copy link
	cemuLog_log(LogType::Socket, "recvfrom({},0x{:08x},{},0x{:x})", hCPU->gpr[3], hCPU->gpr[4], hCPU->gpr[5], hCPU->gpr[6]);
```suggestion cemuLog_log(LogType::Socket, "recvfrom({},0x{:08x},{},0x{:x})", hCPU->gpr[3], hCPU->gpr[4], hCPU->gpr[5], hCPU->gpr[6]); ```
src/Cafe/OS/libs/nsysnet/nsysnet.cpp
Crementif (Migrated from github.com) commented 2023-04-14 05:39:39 -04:00
Copy link
	cemuLog_log(LogType::Socket, "recvfrom_ex({},0x{:08x},{},0x{:x},0x{:08x},0x{:08x},0x{:08x},{})", hCPU->gpr[3], hCPU->gpr[4], hCPU->gpr[5], hCPU->gpr[6], hCPU->gpr[7], hCPU->gpr[8], hCPU->gpr[9], hCPU->gpr[10]);
```suggestion cemuLog_log(LogType::Socket, "recvfrom_ex({},0x{:08x},{},0x{:x},0x{:08x},0x{:08x},0x{:08x},{})", hCPU->gpr[3], hCPU->gpr[4], hCPU->gpr[5], hCPU->gpr[6], hCPU->gpr[7], hCPU->gpr[8], hCPU->gpr[9], hCPU->gpr[10]); ```
src/Cafe/OS/libs/nsysnet/nsysnet.cpp
Crementif (Migrated from github.com) commented 2023-04-14 05:39:55 -04:00
Copy link
	cemuLog_log(LogType::Socket, "sendto({},0x{:08x},{},0x{:x})", hCPU->gpr[3], hCPU->gpr[4], hCPU->gpr[5], hCPU->gpr[6]);
```suggestion cemuLog_log(LogType::Socket, "sendto({},0x{:08x},{},0x{:x})", hCPU->gpr[3], hCPU->gpr[4], hCPU->gpr[5], hCPU->gpr[6]); ```
src/Cafe/OS/libs/nsysnet/nsysnet.cpp
Crementif (Migrated from github.com) commented 2023-04-14 05:40:19 -04:00
Copy link
	cemuLog_log(LogType::Socket, "sendto_multi({},0x{:08x},0x{:08x},{})", hCPU->gpr[3], hCPU->gpr[4], hCPU->gpr[5], hCPU->gpr[6]);
```suggestion cemuLog_log(LogType::Socket, "sendto_multi({},0x{:08x},0x{:08x},{})", hCPU->gpr[3], hCPU->gpr[4], hCPU->gpr[5], hCPU->gpr[6]); ```
src/Cafe/OS/libs/nsysnet/nsysnet.cpp
Crementif (Migrated from github.com) commented 2023-04-14 05:40:36 -04:00
Copy link
	cemuLog_log(LogType::Socket, "sendto_multi_ex({},0x{:08x},0x{:08x},{})", hCPU->gpr[3], hCPU->gpr[4], hCPU->gpr[5], hCPU->gpr[6]);
```suggestion cemuLog_log(LogType::Socket, "sendto_multi_ex({},0x{:08x},0x{:08x},{})", hCPU->gpr[3], hCPU->gpr[4], hCPU->gpr[5], hCPU->gpr[6]); ```
why-keith commented 2023-04-14 09:01:34 -04:00 (Migrated from github.com)
Copy link

Build is only failing on Ubuntu. Struggling to work out what's causing this

Build is only failing on Ubuntu. Struggling to work out what's causing this
Crementif commented 2023-04-14 09:03:54 -04:00 (Migrated from github.com)
Copy link

I think there's some build issues on the main branch, so just ignore it for now.

I think there's some build issues on the main branch, so just ignore it for now.
👍 1
Crementif (Migrated from github.com) approved these changes 2023-04-15 18:08:05 -04:00
Crementif (Migrated from github.com) left a comment
Copy link

Looks good to me!

Looks good to me!
Sign in to join this conversation.
Reviewers
No reviewers
Crementif
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: cemu-project_Mirror/Cemu-2024-03-05#766
No description provided.
Delete branch "logging-migration-socketLog_printf"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?