cemu-project_Mirror/Cemu-2024-03-05
1
0
Fork 0
Code Issues 224 Pull requests 11 Projects Releases Packages Wiki Activity

Disable Discord checkbox based on build option #476

Merged
jn64 merged 1 commit from fix/settings-discord into main 2022-11-11 16:51:50 -03:00
Conversation 5 Commits 1 Files changed 1 +3
jn64 commented 2022-11-11 07:28:39 -03:00 (Migrated from github.com)
Copy link

Disable the Discord checkbox when compiled with -DENABLE_DISCORD_RPC=OFF.

I'm not a programmer (but I play one on TV), so please let me know where the code should go if not here.

screenshot

Disable the Discord checkbox when compiled with `-DENABLE_DISCORD_RPC=OFF`. I'm not a programmer (but I play one on TV), so please let me know where the code should go if not here. ![screenshot](https://user-images.githubusercontent.com/23169302/201319602-24da72a3-b2f9-4c41-925a-687a92fff6c6.png)
marcoluc97 commented 2022-11-11 10:33:51 -03:00 (Migrated from github.com)
Copy link

If true the check box should not be clickable also.

If true the check box should not be clickable also.
jn64 commented 2022-11-11 15:06:30 -03:00 (Migrated from github.com)
Copy link

If true the check box should not be clickable also.

I don't know what you mean.

> If true the check box should not be clickable also. I don't know what you mean.
Masamune3210 commented 2022-11-11 16:10:51 -03:00 (Migrated from github.com)
Copy link

They mean the checkbox next to the greyed out option should be disabled as well to prevent people from enabling it

They mean the checkbox next to the greyed out option should be disabled as well to prevent people from enabling it
Exzap commented 2022-11-11 16:51:20 -03:00 (Migrated from github.com)
Copy link

The text being grayed out means the checkbox is disabled and not clickable. Box and text are part of the same checkbox widget

Anyway LGTM. Thanks!

The text being grayed out means the checkbox is disabled and not clickable. Box and text are part of the same checkbox widget Anyway LGTM. Thanks!
Masamune3210 commented 2022-11-11 17:30:09 -03:00 (Migrated from github.com)
Copy link

Aah, I see. Thanks for the info

Aah, I see. Thanks for the info
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: cemu-project_Mirror/Cemu-2024-03-05#476
No description provided.
Delete branch "fix/settings-discord"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?