docs: add --recursive to the project clone command #220

Merged

qoijjj merged 1 commits from patch-1 into main 2023-09-21 14:17:57 -03:00

Conversation 13 Commits 1 Files Changed 6 +12 -5

qoijjj commented 2023-09-19 03:35:28 -03:00 (Migrated from github.com)

Copy Link

docs: add --recursive to the project clone command

docs: add --recursive to the project clone command

gz83 (Migrated from github.com) requested changes 2023-09-19 04:01:49 -03:00

gz83 (Migrated from github.com) left a comment

Copy Link

From your PR, I found that you only modified the compilation guidelines for the Linux platform. Do the compilation guidelines for other platforms also need to be modified?

From your PR, I found that you only modified the compilation guidelines for the Linux platform. Do the compilation guidelines for other platforms also need to be modified?

qoijjj commented 2023-09-19 16:58:44 -03:00 (Migrated from github.com)

Copy Link

From your PR, I found that you only modified the compilation guidelines for the Linux platform. Do the compilation guidelines for other platforms also need to be modified?

Fixed. I had to add this to the mac instructions as those instructions didn't even include instructions for cloning.

As an aside, the instructions in the windows section say that downloading the zip is an option, but this won't function properly without the submodules.

> From your PR, I found that you only modified the compilation guidelines for the Linux platform. Do the compilation guidelines for other platforms also need to be modified? Fixed. I had to add this to the mac instructions as those instructions didn't even include instructions for cloning. As an aside, the instructions in the windows section say that downloading the zip is an option, but this won't function properly without the submodules.

gz83 (Migrated from github.com) requested changes 2023-09-19 20:06:08 -03:00

gz83 (Migrated from github.com) left a comment

Copy Link

There are still some files that have not been modified. You need to search for git clone https://github.com/Alex313031/thorium.git in the thorium repo to find out which files you need to modify.

There are still some files that have not been modified. You need to search for `git clone https://github.com/Alex313031/thorium.git` in the thorium repo to find out which files you need to modify.

qoijjj commented 2023-09-19 20:10:11 -03:00 (Migrated from github.com)

Copy Link

There are still some files that have not been modified. You need to search for git clone https://github.com/Alex313031/thorium.git in the thorium repo to find out which files you need to modify.

fixed

> There are still some files that have not been modified. You need to search for `git clone https://github.com/Alex313031/thorium.git` in the thorium repo to find out which files you need to modify. fixed

gz83 (Migrated from github.com) requested changes 2023-09-20 01:37:18 -03:00

gz83 (Migrated from github.com) left a comment

Copy Link

The last question, in the modified code, Thorium should be changed to thorium to be consistent with the name of the repo.

The last question, in the modified code, Thorium should be changed to thorium to be consistent with the name of the repo.

qoijjj commented 2023-09-20 02:00:20 -03:00 (Migrated from github.com)

Copy Link

The last question, in the modified code, Thorium should be changed to thorium to be consistent with the name of the repo.

ok I can do that but thorium is capitalized in many places in the docs

> The last question, in the modified code, Thorium should be changed to thorium to be consistent with the name of the repo. ok I can do that but thorium is capitalized in many places in the docs

gz83 commented 2023-09-20 02:35:14 -03:00 (Migrated from github.com)

Copy Link

The last question, in the modified code, Thorium should be changed to thorium to be consistent with the name of the repo.

ok I can do that but thorium is capitalized in many places in the docs

You only need to modify Thorium in the code you modified, and no other modifications are required. For example, line 35 in the install_deps.sh file.

@qoijjj

> > The last question, in the modified code, Thorium should be changed to thorium to be consistent with the name of the repo. > > ok I can do that but thorium is capitalized in many places in the docs You only need to modify Thorium in the code you modified, and no other modifications are required. For example, line 35 in the install_deps.sh file. @qoijjj

qoijjj commented 2023-09-20 02:36:45 -03:00 (Migrated from github.com)

Copy Link

The last question, in the modified code, Thorium should be changed to thorium to be consistent with the name of the repo.

ok I can do that but thorium is capitalized in many places in the docs

You only need to modify Thorium in the code you modified, and no other modifications are required. For example, line 35 in the install_deps.sh file.

@qoijjj

I didn't capitalize it there, it was already capitalized there.

> > > The last question, in the modified code, Thorium should be changed to thorium to be consistent with the name of the repo. > > > > > > ok I can do that but thorium is capitalized in many places in the docs > > You only need to modify Thorium in the code you modified, and no other modifications are required. For example, line 35 in the install_deps.sh file. > > @qoijjj I didn't capitalize it there, it was already capitalized there.

gz83 commented 2023-09-20 02:47:03 -03:00 (Migrated from github.com)

Copy Link

The last question, in the modified code, Thorium should be changed to thorium to be consistent with the name of the repo.

ok I can do that but thorium is capitalized in many places in the docs

You only need to modify Thorium in the code you modified, and no other modifications are required. For example, line 35 in the install_deps.sh file.
@qoijjj

I didn't capitalize it there, it was already capitalized there.

I mean modify Thorium to thorium, like line 35 in install_deps.sh.

@qoijjj

> > > > The last question, in the modified code, Thorium should be changed to thorium to be consistent with the name of the repo. > > > > > > > > > ok I can do that but thorium is capitalized in many places in the docs > > > > > > You only need to modify Thorium in the code you modified, and no other modifications are required. For example, line 35 in the install_deps.sh file. > > @qoijjj > > I didn't capitalize it there, it was already capitalized there. I mean modify Thorium to thorium, like line 35 in install_deps.sh. @qoijjj

qoijjj commented 2023-09-20 02:49:08 -03:00 (Migrated from github.com)

Copy Link

The last question, in the modified code, Thorium should be changed to thorium to be consistent with the name of the repo.

ok I can do that but thorium is capitalized in many places in the docs

You only need to modify Thorium in the code you modified, and no other modifications are required. For example, line 35 in the install_deps.sh file.
@qoijjj

I didn't capitalize it there, it was already capitalized there.

I mean modify Thorium to thorium, like line 35 in install_deps.sh.

@qoijjj

I understand. You want me to change Thorium to thorium. It already was Thorium though, so that is out of scope for this change. I can make a separate PR fixing all of the capitalizations if you prefer.

> > > > > The last question, in the modified code, Thorium should be changed to thorium to be consistent with the name of the repo. > > > > > > > > > > > > ok I can do that but thorium is capitalized in many places in the docs > > > > > > > > > You only need to modify Thorium in the code you modified, and no other modifications are required. For example, line 35 in the install_deps.sh file. > > > @qoijjj > > > > > > I didn't capitalize it there, it was already capitalized there. > > I mean modify Thorium to thorium, like line 35 in install_deps.sh. > > @qoijjj I understand. You want me to change Thorium to thorium. It already was Thorium though, so that is out of scope for this change. I can make a separate PR fixing all of the capitalizations if you prefer.

gz83 commented 2023-09-20 03:04:30 -03:00 (Migrated from github.com)

Copy Link

The last question, in the modified code, Thorium should be changed to thorium to be consistent with the name of the repo.

ok I can do that but thorium is capitalized in many places in the docs

You only need to modify Thorium in the code you modified, and no other modifications are required. For example, line 35 in the install_deps.sh file.
@qoijjj

I didn't capitalize it there, it was already capitalized there.

I mean modify Thorium to thorium, like line 35 in install_deps.sh.
@qoijjj

I understand. You want me to change Thorium to thorium. It already was Thorium though, so that is out of scope for this change. I can make a separate PR fixing all of the capitalizations if you prefer.

There is no need to open a new PR, you only need to complete it in this PR.

@qoijjj

> > > > > > The last question, in the modified code, Thorium should be changed to thorium to be consistent with the name of the repo. > > > > > > > > > > > > > > > ok I can do that but thorium is capitalized in many places in the docs > > > > > > > > > > > > You only need to modify Thorium in the code you modified, and no other modifications are required. For example, line 35 in the install_deps.sh file. > > > > @qoijjj > > > > > > > > > I didn't capitalize it there, it was already capitalized there. > > > > > > I mean modify Thorium to thorium, like line 35 in install_deps.sh. > > @qoijjj > > I understand. You want me to change Thorium to thorium. It already was Thorium though, so that is out of scope for this change. I can make a separate PR fixing all of the capitalizations if you prefer. There is no need to open a new PR, you only need to complete it in this PR. @qoijjj

qoijjj commented 2023-09-20 03:06:07 -03:00 (Migrated from github.com)

Copy Link

The last question, in the modified code, Thorium should be changed to thorium to be consistent with the name of the repo.

ok I can do that but thorium is capitalized in many places in the docs

You only need to modify Thorium in the code you modified, and no other modifications are required. For example, line 35 in the install_deps.sh file.
@qoijjj

I didn't capitalize it there, it was already capitalized there.

I mean modify Thorium to thorium, like line 35 in install_deps.sh.
@qoijjj

I understand. You want me to change Thorium to thorium. It already was Thorium though, so that is out of scope for this change. I can make a separate PR fixing all of the capitalizations if you prefer.

There is no need to open a new PR, you only need to complete it in this PR.

@qoijjj

I will not be doing so as it is out of scope.

> > > > > > > The last question, in the modified code, Thorium should be changed to thorium to be consistent with the name of the repo. > > > > > > > > > > > > > > > > > > ok I can do that but thorium is capitalized in many places in the docs > > > > > > > > > > > > > > > You only need to modify Thorium in the code you modified, and no other modifications are required. For example, line 35 in the install_deps.sh file. > > > > > @qoijjj > > > > > > > > > > > > I didn't capitalize it there, it was already capitalized there. > > > > > > > > > I mean modify Thorium to thorium, like line 35 in install_deps.sh. > > > @qoijjj > > > > > > I understand. You want me to change Thorium to thorium. It already was Thorium though, so that is out of scope for this change. I can make a separate PR fixing all of the capitalizations if you prefer. > > There is no need to open a new PR, you only need to complete it in this PR. > > @qoijjj I will not be doing so as it is out of scope.

gz83 (Migrated from github.com) requested changes 2023-09-20 03:29:30 -03:00

gz83 (Migrated from github.com) left a comment

Copy Link

I will not approve this PR for the time being and will keep this PR in its current status, with final approval by Alex to follow

@Alex313031

I will not approve this PR for the time being and will keep this PR in its current status, with final approval by Alex to follow @Alex313031

Alex313031 commented 2023-09-21 13:28:24 -03:00 (Migrated from github.com)

Copy Link

@gz83 @qoijjj Yeah, can you change it to lowercase thorium instead of Thorium, that was an error on my part.

Also, can you put the --recursive before the URL. Either way will work on the user's side, but the proper way to enter the command would be:

git clone --recursive URLTOCLONE

@gz83 @qoijjj Yeah, can you change it to lowercase thorium instead of Thorium, that was an error on my part. Also, can you put the --recursive before the URL. Either way will work on the user's side, but the proper way to enter the command would be: git clone --recursive URLTOCLONE

qoijjj commented 2023-09-21 14:07:08 -03:00 (Migrated from github.com)

Copy Link

@gz83 @qoijjj Yeah, can you change it to lowercase thorium instead of Thorium, that was an error on my part.

Also, can you put the --recursive before the URL. Either way will work on the user's side, but the proper way to enter the command would be:

git clone --recursive URLTOCLONE

Again, the capitalization is out of scope for this change and is not specific to these lines. I can make a separate PR fixing all of the capitalizations in the repo but will not be doing so in this PR.

> @gz83 @qoijjj Yeah, can you change it to lowercase thorium instead of Thorium, that was an error on my part. > > Also, can you put the --recursive before the URL. Either way will work on the user's side, but the proper way to enter the command would be: > > git clone --recursive URLTOCLONE Again, the capitalization is out of scope for this change and is not specific to these lines. I can make a separate PR fixing all of the capitalizations in the repo but will not be doing so in this PR.

Alex313031 (Migrated from github.com) approved these changes 2023-09-21 14:17:44 -03:00

Alex313031 commented 2023-09-21 14:18:36 -03:00 (Migrated from github.com)

Copy Link

@qoijjj On second thought, I need to update the docs for other stuff too, so I will update the capitalization when I do that as well, so no need to make another PR.

Anyway, I merged it, thanks sir.

@qoijjj On second thought, I need to update the docs for other stuff too, so I will update the capitalization when I do that as well, so no need to make another PR. Anyway, I merged it, thanks sir.

qoijjj commented 2023-09-21 14:19:13 -03:00 (Migrated from github.com)

Copy Link

@qoijjj On second thought, I need to update the docs for other stuff too, so I will update the capitalization when I do that as well, so no need to make another PR.

Anyway, I merged it, thanks sir.

No problem, I was already doing it so here's a PR to fix the capitalizations in all urls for the repo https://github.com/Alex313031/thorium/pull/223

> @qoijjj On second thought, I need to update the docs for other stuff too, so I will update the capitalization when I do that as well, so no need to make another PR. > > Anyway, I merged it, thanks sir. No problem, I was already doing it so here's a PR to fix the capitalizations in all urls for the repo https://github.com/Alex313031/thorium/pull/223

Sign in to join this conversation.

Reviewers

No reviewers

gz83

Alex313031

Labels

Clear labels   

bug

Something isn't working

  

completed

Label for when an action is completed.

  

documentation

Improvements or additions to documentation

  

duplicate

This issue or pull request already exists

  

enhancement

New feature or request

  

good first issue

Good for newcomers

  

hacktoberfest-accepted

hacktoberfest-accepted

  

help wanted

Extra attention is needed

  

information

Describes something that Thorium users may want to be aware of.

  

invalid

This doesn't seem right

  

question

Further information is requested

  

wontfix

This will not be worked on

No Label

bug

completed

documentation

duplicate

enhancement

good first issue

hacktoberfest-accepted

help wanted

information

invalid

question

wontfix

Milestone

Clear milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

No Assignees

1 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Thorium_Archive/thorium#220

No description provided.