From 99b3d6a86ab756df9e3e3c2c05558903136dfdd1 Mon Sep 17 00:00:00 2001 From: Alexander Frick Date: Tue, 22 Oct 2024 10:23:29 -0500 Subject: [PATCH] add more test build args and fix bracket --- .gclient | 4 ++-- arm/third_party/libvpx/BUILD.gn | 1 + infra/DEBUG/win_debug_args.gn | 3 ++- infra/test_build_args.gn | 2 +- infra/test_build_win_args.gn | 4 ++-- 5 files changed, 8 insertions(+), 6 deletions(-) diff --git a/.gclient b/.gclient index 53f5fefd..a4872d0d 100644 --- a/.gclient +++ b/.gclient @@ -8,5 +8,5 @@ solutions = [ }, ] -target_os = [ 'linux', 'win', 'android' ] -target_cpu = [ 'x64', 'x86', 'arm64', 'arm' ] +target_os = [ "linux", "win", "android", "chromeos" ] +target_cpu = [ "x64", "x86", "arm64", "arm" ] diff --git a/arm/third_party/libvpx/BUILD.gn b/arm/third_party/libvpx/BUILD.gn index 5e1015ba..98ab4aad 100644 --- a/arm/third_party/libvpx/BUILD.gn +++ b/arm/third_party/libvpx/BUILD.gn @@ -712,3 +712,4 @@ test("test_libvpx") { configs -= [ "//build/config/compiler:chromium_code" ] configs += [ "//build/config/compiler:no_chromium_code" ] +} diff --git a/infra/DEBUG/win_debug_args.gn b/infra/DEBUG/win_debug_args.gn index 7617deac..3782b5d9 100644 --- a/infra/DEBUG/win_debug_args.gn +++ b/infra/DEBUG/win_debug_args.gn @@ -26,6 +26,7 @@ enable_webui_tab_strip = true is_clang = true treat_warnings_as_errors = false # llvm_force_head_revision = true +# win_enable_cfg_guards = true use_lld = true v8_symbol_level = 2 v8_enable_fast_torque = true @@ -33,7 +34,7 @@ v8_enable_fast_torque = true # v8_enable_maglev = true # v8_enable_turbofan = true v8_enable_wasm_simd256_revec = true -use_v8_context_snapshot = true +# use_v8_context_snapshot = true blink_symbol_level = 2 enable_precompiled_headers = false media_use_ffmpeg = true diff --git a/infra/test_build_args.gn b/infra/test_build_args.gn index 50bd0431..42a1271f 100644 --- a/infra/test_build_args.gn +++ b/infra/test_build_args.gn @@ -29,7 +29,7 @@ v8_enable_fast_torque = true # v8_enable_maglev = true # v8_enable_turbofan = true v8_enable_wasm_simd256_revec = true -use_v8_context_snapshot = true +# use_v8_context_snapshot = true blink_symbol_level = 0 enable_precompiled_headers = false media_use_ffmpeg = true diff --git a/infra/test_build_win_args.gn b/infra/test_build_win_args.gn index 3b131bd3..f9a3c2bf 100644 --- a/infra/test_build_win_args.gn +++ b/infra/test_build_win_args.gn @@ -22,7 +22,7 @@ enable_webui_tab_strip = true is_clang = true treat_warnings_as_errors = false # llvm_force_head_revision = true -win_enable_cfg_guards = true +# win_enable_cfg_guards = true use_lld = true v8_symbol_level = 0 v8_enable_fast_torque = true @@ -30,7 +30,7 @@ v8_enable_fast_torque = true # v8_enable_maglev = true # v8_enable_turbofan = true v8_enable_wasm_simd256_revec = true -use_v8_context_snapshot = true +# use_v8_context_snapshot = true blink_symbol_level = 1 enable_precompiled_headers = false media_use_ffmpeg = true