update todo, and add custom tab width flag

This commit is contained in:
Alexander Frick 2024-09-04 01:33:23 -05:00
parent c2f19837b1
commit 82d84cc52e
4 changed files with 58 additions and 8 deletions

View file

@ -51,6 +51,6 @@ fix thorium and shell portable --temp profile
--M127--
Fix bookmarks bar underline, bookmarks classic folder icons, menu padding for windows, multiple profiles lag, add remove tab search button
Fix bookmarks bar underline, bookmarks classic folder icons, menu padding for windows, multiple profiles lag, add remove tab search button, fix WebUI button radius, add -mcpu to macos
Test non-optimized Thorium, versus optimized Thorium, versus vanilla Chromium, versus vanilla Google Chrome, all at the same revision, to get a better idea of the overall picture.

View file

@ -186,7 +186,7 @@ index bec499693cd91..404316da5bcd2 100644
AddItem(
TabStripModel::CommandAddToReadLater,
diff --git a/chrome/browser/ui/tabs/tab_style.cc b/chrome/browser/ui/tabs/tab_style.cc
index aa9cd30374311..c5d3cbd005dae 100644
index aa9cd30374311..cf477b5fe2794 100644
--- a/chrome/browser/ui/tabs/tab_style.cc
+++ b/chrome/browser/ui/tabs/tab_style.cc
@@ -1,27 +1,32 @@
@ -224,7 +224,34 @@ index aa9cd30374311..c5d3cbd005dae 100644
constexpr int kChromeRefreshTabHorizontalPadding = 8;
class GM2TabStyle : public TabStyle {
@@ -197,11 +202,27 @@ float GM2TabStyle::GetSelectedTabOpacity() const {
@@ -70,8 +75,25 @@ class ChromeRefresh2023TabStyle : public GM2TabStyle {
TabStyle::~TabStyle() = default;
int GM2TabStyle::GetStandardWidth() const {
+
+ const std::string custom_tab_width = base::CommandLine::ForCurrentProcess()->
+ GetSwitchValueASCII("custom-tab-width");
+ if (custom_tab_width == "60") {
+ kTabWidthValue = 60;
+ } else if (custom_tab_width == "120") {
+ kTabWidthValue = 120;
+ } else if (custom_tab_width == "240") {
+ kTabWidthValue = 240;
+ } else if (custom_tab_width == "300") {
+ kTabWidthValue = 300;
+ } else if (custom_tab_width == "400") {
+ kTabWidthValue = 400;
+ } else {
+ kTabWidthValue = 240;
+ }
+
// The standard tab width is 240 DIP including both separators.
- constexpr int kTabWidth = 240;
+ const int kTabWidth = kTabWidthValue;
// The overlap includes one separator, so subtract it here.
return kTabWidth + GetTabOverlap() - GetSeparatorSize().width();
}
@@ -197,11 +219,27 @@ float GM2TabStyle::GetSelectedTabOpacity() const {
}
int ChromeRefresh2023TabStyle::GetTopCornerRadius() const {
@ -254,7 +281,7 @@ index aa9cd30374311..c5d3cbd005dae 100644
}
int ChromeRefresh2023TabStyle::GetTabOverlap() const {
@@ -213,23 +234,43 @@ int ChromeRefresh2023TabStyle::GetTabOverlap() const {
@@ -213,23 +251,43 @@ int ChromeRefresh2023TabStyle::GetTabOverlap() const {
}
gfx::Size ChromeRefresh2023TabStyle::GetSeparatorSize() const {
@ -670,15 +697,15 @@ index 3684e27766834..5ab1c1ce9da63 100644
+ if (features::IsThorium2024()) {
+ switch (id) {
+ case ShapeContextTokens::kBadgeRadius:
+ return 4;
+ return 6;
+ case ShapeContextTokens::kButtonRadius:
+ return 4;
+ case ShapeContextTokens::kComboboxRadius:
+ return 4;
+ return 6;
+ case ShapeContextTokens::kDialogRadius:
+ return 4;
+ return 6;
+ case ShapeContextTokens::kFindBarViewRadius:
+ return 4;
+ return 6;
+ case ShapeContextTokens::kMenuRadius:
+ case ShapeContextTokens::kMenuAuxRadius:
+ return 0;

View file

@ -5,6 +5,25 @@
#ifndef CHROME_BROWSER_THORIUM_FLAG_CHOICES_H_
#define CHROME_BROWSER_THORIUM_FLAG_CHOICES_H_
const FeatureEntry::Choice kCustomTabWidthChoices[] = {
{flags_ui::kGenericExperimentChoiceDefault, "", ""},
{"60",
"custom-tab-width",
"60"},
{"120",
"custom-tab-width",
"120"},
{"240",
"custom-tab-width",
"240"},
{"300",
"custom-tab-width",
"300"},
{"400",
"custom-tab-width",
"400"}
};
const FeatureEntry::Choice kScrollEventChangesTab[] = {
{flags_ui::kGenericExperimentChoiceDefault, "", ""},
{"Always",

View file

@ -43,6 +43,10 @@
"Thorium Rectangular Tabs UI",
"Changes the look of browser tabs to appear with a rectangular shape, similar to Vivaldi or Cent Browser.",
kOsDesktop, SINGLE_VALUE_TYPE("rectangular-tabs")},
{"custom-tab-width",
"Custom Tab Width",
"Allows setting the default tab width, in DIP. Normally 1 DIP = 1 Pixel, and the standard width for tabs is 240.",
kOsAll, MULTI_VALUE_TYPE("kCustomTabWidthChoices")},
{"disable-thorium-dns-config",
"Disable Thorium Custom DNS Config",
"Disables the custom DNS configuration used by default in Thorium. Useful when this config breaks something, "