QUIC: removed excessive check.
The c->udp->dgram may be NULL only if the quic connection was just created: the ngx_event_udp_recvmsg() passes information about datagrams to existing connections by providing information in c->udp. If case of a new connection, c->udp is allocated by the QUIC code during creation of quic connection (it uses c->sockaddr to initialize qsock->path). Thus the check for qsock->path is excessive and can be read wrong, assuming that other options possible, leading to warnings from clang static analyzer.
This commit is contained in:
parent
0d8ddc57e8
commit
9b92d9600f
1 changed files with 1 additions and 1 deletions
|
@ -289,7 +289,7 @@ ngx_quic_update_paths(ngx_connection_t *c, ngx_quic_header_t *pkt)
|
|||
|
||||
qsock = ngx_quic_get_socket(c);
|
||||
|
||||
if (c->udp->dgram == NULL && qsock->path) {
|
||||
if (c->udp->dgram == NULL) {
|
||||
/* 1st ever packet in connection, path already exists */
|
||||
path = qsock->path;
|
||||
goto update;
|
||||
|
|
Loading…
Reference in a new issue