Fijxu/nginx-quic
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

QUIC: fixed memory leak in ngx_quic_send_frames().

Browse source 
The function did not free passed frames in case of error.
This commit is contained in:
Vladimir Homutov 2020-10-07 10:14:02 +03:00
parent 236b7fb58b
commit 5de89a7d8c
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/event/ngx_event_quic.c
View file

@ -3839,6 +3839,7 @@ ngx_quic_send_frames(ngx_connection_t *c, ngx_quic_send_ctx_t *ctx,
len = ngx_quic_create_frame(p, f); len = ngx_quic_create_frame(p, f);
if (len == -1) { if (len == -1) {
ngx_quic_free_frames(c, frames);
return NGX_ERROR; return NGX_ERROR;
} }
@ -3897,11 +3898,13 @@ ngx_quic_send_frames(ngx_connection_t *c, ngx_quic_send_ctx_t *ctx,
pkt.num_len, pkt.trunc); pkt.num_len, pkt.trunc);
if (ngx_quic_encrypt(&pkt, ssl_conn, &res) != NGX_OK) { if (ngx_quic_encrypt(&pkt, ssl_conn, &res) != NGX_OK) {
ngx_quic_free_frames(c, frames);
return NGX_ERROR; return NGX_ERROR;
} }
len = c->send(c, res.data, res.len); len = c->send(c, res.data, res.len);
if (len == NGX_ERROR || (size_t) len != res.len) { if (len == NGX_ERROR || (size_t) len != res.len) {
ngx_quic_free_frames(c, frames);
return NGX_ERROR; return NGX_ERROR;
} }