Fijxu/invidious
8
11
Fork 7
Code Issues 45 Pull requests 8 Projects Releases Packages 1 Wiki Activity Actions

[Bug] Host removal from API breaks thumbnails in third party apps #219

New issue
Open
opened 2025-08-29 15:56:37 -04:00 by mixtrix · 3 comments
mixtrix commented 2025-08-29 15:56:37 -04:00
Copy link

Describe the bug
Thanks for forking and keeping this instance up to date with patches and needed fixes (Redis, especially).

I run this image on my personal instance with Yattee as a client on my end devices - the thumbnails in it don't work however as it extracts the full URL from the API, and doesn't append the path - as a result of this change they were broken:

3bb7924181 (diff-01cdddb164)

I reverted this on a local fork, built the container and deployed it and it fixes the issue I'm encountering.

Would you consider reverting (or I can submit a PR)?

Thanks

Logs

Screenshots

Additional context

**Describe the bug** Thanks for forking and keeping this instance up to date with patches and needed fixes (Redis, especially). I run this image on my personal instance with Yattee as a client on my end devices - the thumbnails in it don't work however as it extracts the full URL from the API, and doesn't append the path - as a result of this change they were broken: https://git.nadeko.net/Fijxu/invidious/commit/3bb792418173d0b8a150ee919f9efc82516b3268?__goaway_challenge=meta-refresh&__goaway_id=14be8ebe7630a3fa38724433fbe53f5b#diff-01cdddb164ea2fd7f9a4fa3ec6e8e64416e80aa4 I reverted this on a local fork, built the container and deployed it and it fixes the issue I'm encountering. Would you consider reverting (or I can submit a PR)? Thanks **Logs** <!-- If applicable, copy the log that appear in the browser page where the error is reported. --> **Screenshots** <!-- If applicable, add screenshots to help explain your problem. --> **Additional context** <!-- Add any other context about the problem here. - Browser (if applicable): - OS (if applicable): -->
Fijxu commented 2025-10-05 18:26:15 -03:00
Owner
Copy link

Thanks for reporting this.

I need to complete support for the Host header there.

Thanks for reporting this. I need to complete support for the Host header there.
mixtrix commented 2026-03-04 20:31:58 -03:00
Author
Copy link

Actually, looking at this again - is the only problem that #{env.request.headers["Host"]} needs added back in here?

Actually, looking at this again - is the only problem that `#{env.request.headers["Host"]}` needs added back [in here](https://git.nadeko.net/Fijxu/invidious/src/commit/3bb792418173d0b8a150ee919f9efc82516b3268/src/invidious/jsonify/api_v1/common.cr#L11)?
Fijxu commented 2026-03-04 20:33:48 -03:00
Owner
Copy link

yes, I need to make env argument available to that function so I can craft a correct URL based on the Host header, I may get my hands on that later

yes, I need to make `env` argument available to that function so I can craft a correct URL based on the Host header, I may get my hands on that later
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
renovate/https-code.forgejo.org-docker-build-push-action-7.x
renovate/https-code.forgejo.org-docker-login-action-4.x
renovate/https-code.forgejo.org-docker-login-action-3.x
renovate/alpine-3.x
renovate/valkey-valkey-9.x
renovate/https-code.forgejo.org-docker-setup-buildx-action-4.x
renovate/docker.io-library-postgres-18.x
renovate/mirror.gcr.io-84codes-crystal-1.x
draft-removal-of-companion-cookie
master-2
backend-color-testing
history
history-testing
testingbuh
testing3
testing2
testing
xdxdxd
experimental
test
external-proxy
debug
test123
No results found.
Labels
Clear labels   
bug
When something is not working as expected.

No labels
bug
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Fijxu/invidious#219
No description provided.