Fijxu/invidious
7
7
Fork 3
Code Issues 24 Pull requests Projects Releases Packages 1 Wiki Activity Actions

redis: replace lib by jgaskins/redis

Browse source 
https://github.com/jgaskins/redis

It's faster and in active development, old one gave me this using a TCP
connection:

test   5.94k (168.34µs) (±56.73%)  144B/op  fastest
test   5.11k (195.76µs) (±58.89%)  144B/op  fastest
test   5.48k (182.33µs) (±73.39%)  144B/op  fastest
test   3.42k (292.56µs) (±66.19%)  144B/op  fastest

meanwhile, the jgaskins/redis one gives:

test   6.96k (143.66µs) (±58.73%)  96.0B/op  fastest
test   6.36k (157.16µs) (±55.95%)  96.0B/op  fastest
test   7.06k (141.65µs) (±57.03%)  96.0B/op  fastest
This commit is contained in:
Fijxu 2025-04-13 02:05:13 -04:00
parent d7aeb1a89f
commit d7a632d51d
Signed by: Fijxu
GPG key ID: 32C1DDF333EDA6A4
4 changed files with 14 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
config/config.example.yml
View file

@ -1072,8 +1072,7 @@ default_user_preferences:
## ##
#extend_desc: false #extend_desc: false
# redis_url: 127.0.0.1:6379 # redis_url: redis://127.0.0.1:6379/0?initial_pool_size=1&max_pool_size=10&checkout_timeout=10&retry_attempts=2&retry_delay=0.5&max_idle_pool_size=50
# redis_socket: /var/run/valkey/valkey.sock
# donation_url: "https://example.com/donate" # donation_url: "https://example.com/donate"
# contact_url: "https://example.com/contact" # contact_url: "https://example.com/contact"
# home_domain: "https://example.com/ # home_domain: "https://example.com/

2
shard.yml
View file

@ -25,7 +25,7 @@ dependencies:
github: athena-framework/negotiation github: athena-framework/negotiation
version: ~> 0.1.1 version: ~> 0.1.1
redis: redis:
github: stefanwille/crystal-redis github: jgaskins/redis
inotify: inotify:
github: petoem/inotify.cr github: petoem/inotify.cr
version: 1.0.3 version: 1.0.3

4
src/invidious/config.cr
View file

@ -107,8 +107,8 @@ class Config
# Database configuration using 12-Factor "Database URL" syntax # Database configuration using 12-Factor "Database URL" syntax
@[YAML::Field(converter: Preferences::URIConverter)] @[YAML::Field(converter: Preferences::URIConverter)]
property database_url : URI = URI.parse("") property database_url : URI = URI.parse("")
property redis_url : String? @[YAML::Field(converter: Preferences::URIConverter)]
property redis_socket : String? property redis_url : URI = URI.parse("")
# Use polling to keep decryption function up to date # Use polling to keep decryption function up to date
property decrypt_polling : Bool = false property decrypt_polling : Bool = false
# Used for crawling channels: threads should check all videos uploaded by a channel # Used for crawling channels: threads should check all videos uploaded by a channel

17
src/invidious/database/videos.cr
View file

@ -97,21 +97,24 @@ module Invidious::Database::Videos
end end
class Redis_ class Redis_
@redis : Redis::PooledClient @redis : Redis::Client
def initialize def initialize
@redis = Redis::PooledClient.new(unixsocket: CONFIG.redis_socket || nil, url: CONFIG.redis_url || nil) @redis = Redis::Client.new(CONFIG.redis_url)
LOGGER.info "Video Cache: Using Redis compatible DB to store video cache" LOGGER.info "Video Cache: Using Redis compatible DB to store video cache"
LOGGER.info "Connecting to Redis compatible DB" LOGGER.info "Connecting to Redis compatible DB"
if @redis.ping # #ping method is not available in this Redis library
LOGGER.info "Connected to Redis compatible DB via unix domain socket at '#{CONFIG.redis_socket}'" if CONFIG.redis_socket # https://github.com/jgaskins/redis/issues/53
LOGGER.info "Connected to Redis compatible DB via TCP socket at '#{CONFIG.redis_url}'" if CONFIG.redis_url # if @redis.ping
if @redis.run({"PING"}) == "PONG"
# LOGGER.info "Connected to Redis compatible DB via unix domain socket at '#{CONFIG.redis_socket}'" if CONFIG.redis_socket
LOGGER.info "Connected to Redis compatible DB at '#{CONFIG.redis_url}'" if CONFIG.redis_url
end end
end end
def set(video : Video, expire_time) def set(video : Video, expire_time)
@redis.set(video.id, video.info.to_json, expire_time) @redis.set(video.id, video.info.to_json, ex: expire_time)
@redis.set(video.id + ":time", video.updated, expire_time) @redis.set(video.id + ":time", video.updated.to_s, ex: expire_time)
end end
def del(id : String) def del(id : String)